Take circular GossipVerifier reference by Arc
#3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our current architecture requires `GossipVerifier`'s type signature to include a circular reference to itself. Previously, we directly gave that as `Self`, which however did not work when setting it dynamically under all circumstances. Here we take `Self` by `Arc` mitigate this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3369.
Our current architecture requires
GossipVerifier's type signature to include a circular reference to itself. Previously, we directly gave that asSelf, which however did not work when setting it dynamically under all circumstances. Here we takeSelfbyArcmitigate this issue.This change was proposed by @TheBlueMatt in #3369 (comment), I have yet to confirm it works as expected myself.