Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trader.ListAccounts OutPoint txid not reverse byte order #408

Open
cwispp opened this issue Nov 2, 2022 · 1 comment
Open

Trader.ListAccounts OutPoint txid not reverse byte order #408

cwispp opened this issue Nov 2, 2022 · 1 comment

Comments

@cwispp
Copy link

cwispp commented Nov 2, 2022

when using grpc ListAccounts, the account outPoint txid is not reverse byte order

@guggero
Copy link
Member

guggero commented Nov 3, 2022

That's kind of an implicit API level design Pool shares with lnd. If a TXID is of type bytes in the proto, then it means the TXID is in the internal (non-reversed) representation that corresponds to the transaction hash. That is the case everywhere the Outpoint RPC message is used. The CLI explicitly converts this representation to the human-readable (reversed) form when presenting it to the user.

If an outpoint or TXID has the type string on the RPC it means it is hex encoded in the human-readable (reversed) format.

I guess this should just be documented better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants