Skip to content

Commit

Permalink
scripts: kill lnd on windows to access log files
Browse files Browse the repository at this point in the history
For some reason lnd doesn't properly shut down on some windows itests,
and the process still running makes it impossible to access its log
files.
So for the Windows integration test, we attempt to kill the whole
process tree once the process indicates it is done.
  • Loading branch information
guggero committed Oct 9, 2023
1 parent 4f34606 commit 5458eaa
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,11 @@ jobs:

- name: run itest
run: make itest-parallel windows=1

- name: kill any remaining lnd processes
if: ${{ failure() }}
shell: powershell
run: taskkill /IM lnd-itest.exe /T /F

- name: Zip log files on failure
if: ${{ failure() }}
Expand Down
7 changes: 3 additions & 4 deletions scripts/itest_parallel.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,12 @@ for pid in "${pids[@]}"; do

# Overwrite the exit code if current itest doesn't return 0.
if [ $current_exit_code -ne 0 ]; then
# Only write the exit code of the first failing itest.
if [ $exit_code -eq 0 ]; then
# Only write the exit code of the first failing itest.
if [ $exit_code -eq 0 ]; then
exit_code=$current_exit_code
fi
fi
fi
done


# Exit with the exit code of the first failing itest or 0.
exit $exit_code

0 comments on commit 5458eaa

Please sign in to comment.