Skip to content

Commit

Permalink
Merge pull request #9214 from guggero/release-go-version-check
Browse files Browse the repository at this point in the history
makefile+scripts: add Go version check to release command
  • Loading branch information
guggero authored Oct 23, 2024
2 parents b4ef22b + 7919b3f commit e488002
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ release-install:
release: clean-mobile
@$(call print, "Releasing lnd and lncli binaries.")
$(VERSION_CHECK)
./scripts/release.sh build-release "$(VERSION_TAG)" "$(BUILD_SYSTEM)" "$(RELEASE_TAGS)" "$(RELEASE_LDFLAGS)"
./scripts/release.sh build-release "$(VERSION_TAG)" "$(BUILD_SYSTEM)" "$(RELEASE_TAGS)" "$(RELEASE_LDFLAGS)" "$(GO_VERSION)"

#? docker-release: Same as release but within a docker container to support reproducible builds on BSD/MacOS platforms
docker-release:
Expand Down
14 changes: 13 additions & 1 deletion scripts/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,23 @@ function check_tag_correct() {

# build_release builds the actual release binaries.
# arguments: <version-tag> <build-system(s)> <build-tags> <ldflags>
# <go-version>
function build_release() {
local tag=$1
local sys=$2
local buildtags=$3
local ldflags=$4
local goversion=$5

# Check if the active Go version matches the specified Go version.
active_go_version=$(go version | awk '{print $3}' | sed 's/go//')
if [ "$active_go_version" != "$goversion" ]; then
echo "Error: active Go version ($active_go_version) does not match \
required Go version ($goversion)."
exit 1
fi

echo "Building release for tag $tag with Go version $goversion"

green " - Packaging vendor"
go mod vendor
Expand Down Expand Up @@ -202,7 +214,7 @@ function build_release() {
function usage() {
red "Usage: "
red "release.sh check-tag <version-tag>"
red "release.sh build-release <version-tag> <build-system(s)> <build-tags> <ldflags>"
red "release.sh build-release <version-tag> <build-system(s)> <build-tags> <ldflags> <go-version>"
}

# Whatever sub command is passed in, we need at least 2 arguments.
Expand Down

0 comments on commit e488002

Please sign in to comment.