-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contractcourt: fix potential panic during startup #7936
contractcourt: fix potential panic during startup #7936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
8eba19c
to
395e70c
Compare
395e70c
to
4d85107
Compare
4d85107
to
e78bc83
Compare
Related to this fix 5a28582, we may not have the historical data for old channels so we skip it here too.
e78bc83
to
4ca3658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. Though I would like to hear from the user who reported this that the startup is fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦜
Related to this fix 5a28582, we may not have the historical data for old channels so we skip it here too.
Fixes #7935