Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contractcourt: fix potential panic during startup #7936

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

yyforyongyu
Copy link
Member

@yyforyongyu yyforyongyu commented Aug 29, 2023

Related to this fix 5a28582, we may not have the historical data for old channels so we skip it here too.

Fixes #7935

@yyforyongyu yyforyongyu added this to the v0.17.0 milestone Aug 29, 2023
@yyforyongyu yyforyongyu self-assigned this Aug 29, 2023
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Related to this fix 5a28582, we may not
have the historical data for old channels so we skip it here too.
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Though I would like to hear from the user who reported this that the startup is fixed.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦜

@Roasbeef Roasbeef merged commit d24f12b into lightningnetwork:master Aug 29, 2023
22 of 24 checks passed
@yyforyongyu yyforyongyu deleted the fix-resolver-panic branch August 29, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: invalid memory address or nil pointer dereference
4 participants