itest: kill lnd on windows to access log files #8015
Conversation
guggero
force-pushed
the
itest-killall
branch
7 times, most recently
from
160d884 to
9b41863
Compare
guggero
force-pushed
the
itest-killall
branch
from
9b41863 to
50e0692
Compare
|
@yyforyongyu yesss, this latest version seems to work (going to clean up the diff again now). Here's the log of the node that didn't want to shut down: |
Yeaaah finally!🎉 |
|
@guggero, remember to re-request review from reviewers when ready |
.github/workflows/main.yml
Outdated
|
|
||
| - name: build release for all architectures | ||
| run: make release | ||
| # TODO(guggero): revert when the windows itest is working. |
There was a problem hiding this comment.
let's do this and let it run and merge it?🤩
There was a problem hiding this comment.
Done! Changed the base to 0-18-staging-rebased, as we are dependent on #8067 (the itest_parallel.sh was only added there).
For some reason lnd doesn't properly shut down on some windows itests, and the process still running makes it impossible to access its log files. So for the Windows integration test, we attempt to kill the whole process tree once the process indicates it is done.
|
Oops, closed by accident by deleting the |
For some reason lnd doesn't properly shut down on some windows itests, and the process still running makes it impossible to access its log files.
So for the Windows integration test, we attempt to kill the whole process tree once the process indicates it is done.