[1/7] lnwire: add new Gossip 1.75 messages #8044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
force-pushed
the
g175Messages
branch
from
610fad0 to
20970c8
Compare
ellemouton
force-pushed
the
g175Messages
branch
from
20970c8 to
9c03cfa
Compare
21 tasks
ellemouton
force-pushed
the
g175Messages
branch
from
9c03cfa to
0491785
Compare
ellemouton
force-pushed
the
g175Messages
branch
2 times, most recently
from
f06fad6 to
ba60010
Compare
ellemouton
force-pushed
the
g175Messages
branch
4 times, most recently
from
3647e34 to
4074a8c
Compare
ellemouton
changed the title
ellemouton
force-pushed
the
g175Messages
branch
from
4074a8c to
0695472
Compare
ellemouton
force-pushed
the
g175Messages
branch
2 times, most recently
from
b0d6a0e to
7d3db71
Compare
ellemouton
force-pushed
the
g175Messages
branch
from
7d3db71 to
6ee21d7
Compare
ellemouton
changed the title
Crypt-iQ
reviewed
Dec 13, 2023
Roasbeef
requested changes
Jan 5, 2024
ellemouton
force-pushed
the
g175Messages
branch
from
6ee21d7 to
53084cb
Compare
Roasbeef
approved these changes
Sep 16, 2024
yyforyongyu
approved these changes
Sep 18, 2024
| } | ||
|
|
||
| keys = append(keys, bitcoinKey1, bitcoinKey2) | ||
| } else { |
There was a problem hiding this comment.
Q: what if only one of the keys is set, like bitcoinKey1 is set but not bitcoinKey2?
There was a problem hiding this comment.
it will then fall to the else branch below which will fetch the on-chain script.
ie, we dont explicitly need to not allow that case I dont think. It could maybe be a valid future message potentially.
In preparation for adding a new message, AnnounceSignatures2 along with an AnnounceSignatures interface, we rename the existing message to AnnounceSignatures1.
In preparation for adding the new ChannelAnnouncement2 message along with a ChannelAnnouncement interface, we rename the existing message to ChannelAnnouncement1.
In preparation for adding a new ChannelUpdate2 message and a ChannelUpdate interface, we rename the existing message to ChannelUpdate1.
In preparation for Gossip 1.75, we add new TLV's to the `ChannelReady` message. Namely: `AnnouncementBitcoinNonce` and `AnnouncementNodeNonce`. These will be used to exchange nones required for producing the partial signature to be send in the `AnnouncementSignatures2` message. The type numbers for these new fields are even because if they are set, then a peer is expecting its peer to understand gossip 1.75 and the new fields.
Add new FirstBlockHeight and BlockRange TLV fields to the GossipTimestampRange message. This will be used to query for Gossip 1.75 messages which are timestamped using block height instead of Unix timestamps.
Add a AnnounceSignatures interface and ensure that AnnounceSignatures1 implements it.
So that it can be re-used elsewhere.
This commit makes an lnwallet.BlockChainIO available to the gossiper and uses it to construct a helper that can be used to fetch the pk script for a given SCID. This will be used for channel announcement verification in an upcoming commit.
from the graph package.
Add a new ChannelAnnouncement interface and ensure that ChannelAnnouncement1 implements it.
In this commit, a new ChannelUpdate interface is added and ChannelUpdate1 is made to implement the new interface.
And ensure that it implements the AnnounceSignatures interface.
And ensure that it implements the ChannelAnnouncement interface.
This commit adds the MsgHash helper function which can be used to calculate the digest of a message to be signed using schnorr signatures.
Add the new ChannelUpdate2 message and ensure that it implements the ChannelUpdate interface.
ellemouton
force-pushed
the
g175Messages
branch
from
a826e6e to
077273e
Compare
|
Thanks for the review @Roasbeef & @yyforyongyu 🔈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards the Gossip 1.75 epic
In this PR, the definitions for the new gossip messages defined in the
taproot-gossip proposal are implemented. This includes:
announcement_signatures_2channel_announcement_2channel_update_2Various updates are also made to some existing messages such as
channel_readyandgossip_timestamp_rangeI expect there to still be a few updates to these messages as the proposal progresses