Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information when a co-op close is failing. #8090

Merged

Conversation

ziggie1984
Copy link
Collaborator

@ziggie1984 ziggie1984 commented Oct 12, 2023

Change Description

Resulting from discussions in the noderunner group where someone could not co-op close a channel but was not able to understand why:

Logs where only showing:

==> /var/log/syslog <==
Oct 10 13:21:09 lnd[1591]: 2023-10-10 13:21:09.933 [INF] PEER: Peer(xxx): Local close channel request delivered to peer
==> /home/bitcoin/.lnd/logs/bitcoin/mainnet/lnd.log <==2023-10-10 13:21:09.950 [ERR] PEER: Peer(xxx): failed link shutdown: link failed to shutdown

This had the appearance that the peer somehow was not willing to cooperate ("request delivered to peer"), now we give the user better feedback what's happening.

Now would be:

2023-10-12 11:22:08.349 [INF] PEER: Peer(0355402a07589a522375f83b6f6c42c4144d219ec3810e0a2aefb8ae99bdabd095): Local close channel request is going to be delivered to the peer
2023-10-12 11:22:08.367 [INF] PEER: Peer(0355402a07589a522375f83b6f6c42c4144d219ec3810e0a2aefb8ae99bdabd095): Delivery addr for channel close: bcrt1p2szcuwgt3dzkf5awkw27xzjrshf6vdsrx0y5sqj67w6flueh0pwqelcxp2
2023-10-12 11:22:08.367 [INF] HSWC: ChannelLink(877b1cd70661da033ab740928b6d0ca9ee6dcf023859f8f38e1381d45b036efc:0): Channel is in an unclean state (lingering updates), graceful shutdown of channel link not possible
2023-10-12 11:22:08.367 [ERR] PEER: Peer(0355402a07589a522375f83b6f6c42c4144d219ec3810e0a2aefb8ae99bdabd095): failed link shutdown: link failed to shutdown

And for the receiver:
[lncli] rpc error: code = Unknown desc = failed handling co-op closing request with (try force closing it instead): link failed to shutdown

@ziggie1984 ziggie1984 force-pushed the add-additional-log-chan-closure branch 2 times, most recently from 4494eb4 to e020b05 Compare October 12, 2023 09:14
@ziggie1984 ziggie1984 marked this pull request as ready for review October 12, 2023 09:24
@saubyk saubyk added P1 MUST be fixed or reviewed logging Related to the logging / debug output functionality no-changelog labels Oct 12, 2023
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Could you remove the skip ci flag and let the build run? Think we wanna disable this flag as previously we've had changes we thought were small enough to skip the CI while they turned out to violate the linters.

@ziggie1984 ziggie1984 force-pushed the add-additional-log-chan-closure branch from e020b05 to e4dd911 Compare October 13, 2023 18:37
Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🙏

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero guggero added this to the v0.17.1 milestone Oct 17, 2023
@guggero guggero merged commit 82838e4 into lightningnetwork:master Oct 17, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Related to the logging / debug output functionality no-changelog no-itest P1 MUST be fixed or reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants