[3/3] Graph RIP: multi: RPC GraphSource #9265

These should be addressed in a refactor PR.

Before we continue to add more implementations of the GraphSource interface, we need to make sure that all implementations behave the same way if a resource (node or channel) is not found. Either no error should be returned or it should be clearly defined in the method comment which error to expect if the resource is not found. This will be important later when we want to address both a local and remote graph source so that we can handle the cases where a resource is not found in one source and then address the other source rather than erroring out.

for when the node in question is not found. This is consistent with other methods such as GetNodeInfo. This will allow us later on to switch out a grpc NotFound error with the expected error we implement the GraphSource interface with a grpc client.

This field is only ever written to and never read from. We remove it so that later on when we want to convert NetAddress into and from a protobuf message, we don't need to encode the ChainHash uneccessarily. This was included in NetAddress when the plan was still to have LND cater for different blockchains.

We'll make use of this field later when implementing the rpc version of the IsPublic method of the GraphSource interface.

We'll make use of this field later when implementing the rpc version of the GraphSource interface.

This commit mostly consists of boilerplate code that adds the new graphrpc server and provides it with the config it needs. The server is then implemented by graphrpc.Server.

So that we can import it in other packages without causing a circular dependency.

In this commit, a grpc version of the GraphSource interface is implemented. It does so by connecting to server that serves both the lnrpc.LightningClient service along with the graphrpc.GraphClient service. Each method on the GraphSource interface is implemented and tested.

Mux multiplexes the results from a local node GraphSource (likely backed by a ChannelGraph) and a remote graph source (likely backed by a graphrpc.Client) to form a new implementation of GraphSource that can be used by LND for graph queries.

When set, LND will not advertise the gossip queries feature bit and it will not initiate gossip syncing with any peer.

We already set `nobootstrap` in the default node flags for itest nodes, so we can remove this check now. This will allow us to later test bootstrapping in an itest.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3/3] Graph RIP: multi: RPC GraphSource #9265

[3/3] Graph RIP: multi: RPC GraphSource #9265

Commits on Nov 28, 2024

[3/3] Graph RIP: multi: RPC GraphSource #9265

Are you sure you want to change the base?

[3/3] Graph RIP: multi: RPC GraphSource #9265

Commits on Nov 28, 2024