-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenTelemetry configuration options #127
Comments
+1 |
Hey hey - all these configuration should work just fine. The Java Launcher simply pre-configures some parameters (e.g. OTLP ingestion path, OTLP headers), but anything else works fine and transparently. Are you having a specific problem or a use case is not working as expected? |
@carlosalberto I can't log the
I took a quick look to the project. [I might be missing something essential but...] it seems that some Opentelemetry configs are not read by the VariablesConverter class, so the agent is always configured with the default values, in this particular example: |
Interesting. Variables converter pre-sets some values, but properties should flow transparently. Will take a second look to double check what's going on. |
@carlosalberto any news on this?:) |
Hi @jenni! Apologies for the delay here, @carlosalberto is coming back from PTO next week and will follow up here. |
@codeboten @carlosalberto it's a pity that it's been 2 months since I opened this issue and haven't heard back from anyone. I have tried to look into it myself but I can't start the project as some environment variables are missing and there's no documentation on how to contribute here. I guess the best would be to add some docs or simply deprecate the repo. |
Is your feature request related to a problem? Please describe.
OpenTelemetry has a list of supported configurations that the LS Launcher is missing. Example:
DB statement sanitization: https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#db-statement-sanitization
Describe the solution you'd like
Support all available config options for the OpenTelemetry agent.
The text was updated successfully, but these errors were encountered: