Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the app (un)install receiver #100

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

SebiderSushi
Copy link
Contributor

@SebiderSushi SebiderSushi commented Nov 13, 2017

Issues covered: closes #94 closes #113 closes #114
PRs included: closes #110
Feature branches included: SebiderSushi:fix_installtime_froyo_catchblock

@SebiderSushi SebiderSushi force-pushed the redesign_un_install_receiver branch 6 times, most recently from 4b7f6a4 to 1350adb Compare November 16, 2017 20:40
@SebiderSushi SebiderSushi force-pushed the redesign_un_install_receiver branch 2 times, most recently from fc8a845 to e6466af Compare November 22, 2017 15:32
@SebiderSushi
Copy link
Contributor Author

Okay i've tested this once now for Oreo and it did't work right;
Probably something concerning Broadcasts & JobSheduler.
Should also give an option to reenable refreshing onCreate or even onResume.

@SebiderSushi
Copy link
Contributor Author

SebiderSushi commented Feb 22, 2019

This commit could be applied as is and work correctly if you would be ready to roll back to targeting SDK Version 25 again @ligi.
If there are any implications in that (e.g. Google Play related) or if you just really want to target android 8 then let me know and I'll update my patches to work with oreo.

Otherwise I don't see any reason to target Oreo and since it's majorly breaking app refreshing functionality as it is implemented right now (even on master) so rolling back and merging this would really be better in my opinion. [The lazy solution]

@ligi
Copy link
Owner

ligi commented Feb 22, 2019

Unfortunately I need to target 26 now if I want to upload to google play:
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html

@SebiderSushi
Copy link
Contributor Author

Just saw it in Android Lint too .-.

I see three options:

  • Release this to F-Droid and push a Version to Google Play that updates in onResume() untli Oreo compliance is implemented
  • Release this to F-Droid and skip one release on Google Play until Oreo compliance is implemented
  • Implement Oreo compliance right away for everything

@ligi
Copy link
Owner

ligi commented Feb 23, 2019

I would really like to let f-droid version and google play not drift apart - this only makes problems in the long run.
I only see option #3 as the way to go

@SebiderSushi
Copy link
Contributor Author

Okay, digging into it.

@SebiderSushi
Copy link
Contributor Author

If anyone can, please test this patch so it will prove to be stable enough for merge.

@SebiderSushi SebiderSushi force-pushed the redesign_un_install_receiver branch 4 times, most recently from b953f4d to bcce4b8 Compare July 1, 2019 04:11
@SebiderSushi
Copy link
Contributor Author

SebiderSushi commented Jul 1, 2019

I consider this patch complete now. This means it is not ready for merge but should be fully functional and that any changes from this point will only be code cleanup and bug fixes.
Once the testing build has been thoroughly tested and once someone has reviewed my changes, possibly spotting bad practices or code mess, i will go on and polish it up for merge.

@SebiderSushi
Copy link
Contributor Author

Another thing: As you can see in the change listing, some changes in my commit result from using the "Reformat Code" action in Android Studio (with default settings). Of course this is out of scope of this commit and will be removed before merge. I would nontheless welcome it if generally all FAST code would be reformatted in a dedicated commit to follow at least some code style. After all, it should make life easier for everyone working with FAST source code.

What do you think @ligi? Is this a good suggestion or do you want to keep all existing code as is and only apply style guidelines to newly contributed code?

@SebiderSushi SebiderSushi force-pushed the redesign_un_install_receiver branch 3 times, most recently from bcce4b8 to 0f0443e Compare July 2, 2019 01:46
@nerd190
Copy link

nerd190 commented Apr 22, 2020

Side note... I F*in love this app, and now SebiderSushi too for all your efforts! :D

@SebiderSushi SebiderSushi deleted the redesign_un_install_receiver branch October 19, 2022 11:08
its code is entirely duplicated in AppInfoListStore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two settings apps. doesn't refresh newly installed apps. Redesign the app (un)install receiver
3 participants