-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using imago based tool as replacement for qemu-img #3210
Comments
What do you mean by "packing a tool" ? |
Assuming there is a tool using this library, if it is available in brew, is this good enough for our needs? Or we want to be able to use the single file standalone lima executable? |
Yes, but the current go-qcow2reader should be kept as a fallback option. |
If we keep go-qcow2reader there is point in using another tool. |
The tool might be faster? |
I don't understand the suggestion. If we use an external tool, why would we not use |
I think it was about being able to configure the But |
@AkihiroSuda mentioned before that installing qemu-img may be hard impossible in some cases. Maybe in this case depending on another tool will be the same issue? Anyway if we don't want any dependency, we need to use the go qcow2 reader. |
We could provide the tools as separate projects, if it is really important. We considered this for QEMU as well. The main issue here (for starters) seems to be that the Rust program does not exist yet, only the Rust library? |
Maybe we can create a wrapper that can use multiple external tools: if it finds |
We are using https://github.com/lima-vm/go-qcow2reader to convert qcow2 images to raw.
For uncompressed images we have good performance (similar to qemu-img), but for uncompressed images (the common case for cloud images) we are much slower.
There is the imago rust library supporting reading and writing qcow2 images, used by libkrun to run vms sing qcow2 images.
We can use it or a simple tool written with it to do qcow2 conversion, and save the work of maintaining a pretty complicated go code.
Converting images is very slow, and delegating the work to external tool is better than adding complicated libraries in the same process.
Tasks:
The text was updated successfully, but these errors were encountered: