Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify QEMU write path #2923

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Simplify QEMU write path #2923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pkg/vz/network_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,13 +109,12 @@ func (c *qemuPacketConn) Write(b []byte) (int, error) {
return 0, err
}

start := 0
for start < size {
nw, err := c.Conn.Write(b[start:])
for len(b) != 0 {
n, err := c.Conn.Write(b)
if err != nil {
return 0, err
}
start += nw
b = b[n:]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new code saves one line, but it makes the intent of the code less clear, and in case of errors it is harder to report how many bytes we copied. I would keep the code as is but lets see what others think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is pretty common in the standard library: https://cs.opensource.google/search?q=for%5C%20len%5C(.*%5C)%5C%20(!%3D%7C%3E)%5C%200&sq=&ss=go%2Fgo

}
return size, nil
}
Expand Down
Loading