Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#625 add show and hide radio button to calendars list #626

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

#625 add show and hide radio button to calendars list #626

wants to merge 1 commit into from

Conversation

asmaNode
Copy link
Contributor

@asmaNode asmaNode commented Dec 22, 2021 •
edited
Loading

Updated demo :

showANdHideCalendars.mp4

The solution:

The radio button of group list is active if at least one calendar is selected . The idea is to update the logic og toogle calendar with adding new params :

  • CalendarType: to detect from any list item the toggle is received and activate the radio button concerned
  • Length of calendar by type: we need to retreive the length from the parent component

This update will affect :

  • the storage : all the calendars must be stored by their type
  • the toggle function : we must compare in each call the length calendars and the length of hidden one
  • Th hidden calendars function : we must retreive this list by their type

@asmaNode asmaNode marked this pull request as draft December 22, 2021 13:21
@asmaNode asmaNode changed the title #625 #625 add show , hide to calendars list Dec 23, 2021
@asmaNode asmaNode changed the title #625 add show , hide to calendars list #625 add show and hide radio button to calendars list Dec 23, 2021
fabienmoyon
fabienmoyon reviewed Dec 27, 2021
View reviewed changes
Copy link
Member

@fabienmoyon fabienmoyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to rebase to remove linagora#623 remove subheader when it is desktop and update css without commit

...a.esn.calendar/app/components/calendars-list/items/item/configuration/configuration-list.pug Outdated Show resolved Hide resolved
src/linagora.esn.calendar/app/components/calendars-list/user/user-calendars-list.pug Show resolved Hide resolved
src/linagora.esn.calendar/app/components/calendars-list/user/user-calendars-list.pug Outdated Show resolved Hide resolved
@asmaNode asmaNode marked this pull request as ready for review January 7, 2022 06:34
@asmaNode asmaNode self-assigned this Jan 7, 2022
@alagane
Copy link
Member

alagane commented Jan 7, 2022

There is a problem, clicking the toggle will expand or retract the menu.
I don't think this is intended.

@alagane
Copy link
Member

alagane commented Jan 7, 2022

Could you please explain what behavior your are trying to make?
I mean, what should happen when you click to the toggle button.

@asmaNode
Copy link
Contributor Author

the toggle button will hide all calendars and show only calendar wich are already selected

@asmaNode
Copy link
Contributor Author

@alagane about the expand menu i had created new directive to toggle menu in calendar list .I used the same directive(esn-toggle) applying modifications to suit our need

@asmaNode asmaNode linked an issue Jan 11, 2022 that may be closed by this pull request
As a User I want to be able to hide or show all calendars in one click #625
Open
@asmaNode asmaNode marked this pull request as draft January 17, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabienmoyon fabienmoyon fabienmoyon left review comments

@rezk2ll rezk2ll rezk2ll left review comments

@alagane alagane alagane left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@asmaNode asmaNode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a User I want to be able to hide or show all calendars in one click
4 participants
@asmaNode @alagane @rezk2ll @fabienmoyon