Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links in note’s event not clickable #630

Open
asmaNode opened this issue Jan 25, 2022 · 3 comments · Fixed by #631
Open

Links in note’s event not clickable #630

asmaNode opened this issue Jan 25, 2022 · 3 comments · Fixed by #631
Labels
bug Something isn't working medium

Comments

@asmaNode
Copy link
Contributor

asmaNode commented Jan 25, 2022 •
edited
Loading

Priority: high

Description:
we are unable to detect links ( mails also ) in notes area

Environment: Production

Steps to reproduce:

1. Create an event  in openpaas
2. Create text with links in notes
3. Click on a link

Expected result:

Links must be clickable
Example from google calendar experience :

notes with clickable link

Demo of the bug:

link.not.clickable.mp4
@asmaNode asmaNode added bug Something isn't working critical Issue needs to be fixed immediately labels Jan 25, 2022
@fabienmoyon
Copy link
Member

cases that expect a link :

  • links
  • hyperlinks
  • mailto
  • tel
  • location
  • videoconferences

For this you can use directives already present in ESN like op-inbox-compose and DomPurity

mailto : a(ng-href='mailto:{{user.address}}', op-inbox-compose, op-inbox-compose-users='[user]')

link and hyperlinks with target:_blank : https://github.com/linagora/esn-frontend-common-libs/blob/1781b81f788cd33d6c7f4ddea27ab1fe68ee9ac9/src/frontend/js/modules/core.js#L255

@asmaNode
Copy link
Contributor Author

asmaNode commented Jan 25, 2022 •
edited
Loading

I suggest this solution https://github.com/gregjacobs/Autolinker.js , will test it

asmaNode added a commit to asmaNode/esn-frontend-calendar that referenced this issue Jan 28, 2022
@asmaNode
linagora#630 add autolink filter to description field
ac12d37
asmaNode added a commit to asmaNode/esn-frontend-calendar that referenced this issue Jan 28, 2022
@asmaNode
linagora#630 add autolink filter to description field
8ad1231
asmaNode added a commit to asmaNode/esn-frontend-calendar that referenced this issue Jan 28, 2022
@asmaNode
linagora#630 add autolink filter to description field
6643938
@asmaNode
Copy link
Contributor Author

PR:
#631

@asmaNode asmaNode linked a pull request Jan 28, 2022 that will close this issue
#630 add autolink filter to description field #631
Merged
asmaNode added a commit to asmaNode/esn-frontend-calendar that referenced this issue Feb 11, 2022
@asmaNode
linagora#630 add autolink filter to description field
9adb1c9
alagane added a commit that referenced this issue Feb 14, 2022
@alagane
Merge pull request #631 from asmaNode/#630
a0e11fd 
#630 add autolink filter to description field
@renaudboyer renaudboyer added medium and removed critical Issue needs to be fixed immediately labels Feb 15, 2022
@renaudboyer renaudboyer reopened this Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#630 add autolink filter to description field asmaNode/esn-frontend-calendar
3 participants
@fabienmoyon @renaudboyer @asmaNode