[Multitenant] BlobStore API refactoring

[vttranlina]

Epic: #5263

How

1. Refactor BlobStore

Before proceeding with the refactor, we need to introduce the following classes:

• Tenant

public record Tenant(String name) {
    public static Tenant from(Domain domain) {
        return new Tenant(domain.asString());
    }
    public String asString() {
        return name;
    }
}

• Bucket

public record Bucket(BucketName bucketName, Optional<Tenant> tenant) {
    public static Bucket of(BucketName bucketName) {
        return new Bucket(bucketName, Optional.empty());
    }
}

For each method in BlobStore, we need to create a new API where the input argument changes from BucketName to Bucket.

Example:

• Current: InputStream read(BucketName bucketName, BlobId blobId);
• New API: InputStream read(Bucket bucket, BlobId blobId);
• In the interface, modify the existing API as a default method. For example:

default InputStream read(BucketName bucketName, BlobId blobId) {
    return read(Bucket.of(bucketName), blobId);
}

2. Refactor BlobStoreDAO

• Apply a similar refactoring as in BlobStore, adapting the API to use the new Bucket class.

3. Refactor the related class

• BlobStore implementations:
  • CachedBlobStore
  • DeDuplicationBlobStore
  • MetricableBlobStore
  • PassThroughBlobStore
• BlobStoreDAO implementations:
  • AESBlobStoreDAO, CassandraBlobStoreDAO, MemoryBlobStoreDAO: Consider whether to throw new UnsupportException? or try to adapt with current way (Optional[Tenant] = empty) ?
  • File multitenancy
  • S3BlobStoreDAO (will do in another ticket)

[Arsnael]

AESBlobStoreDAO, CassandraBlobStoreDAO, MemoryBlobStoreDAO: Consider whether to throw new UnsupportException? or try to adapt with current way (Optional[Tenant] = empty) ?

I personally think Optional[Tenant] = empty for now, until we do proper implementation? That should keep the current behavior then correct?

[quantranhong1999]

apache#2485

[quantranhong1999]

I put this on hold.