Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CNB] Ensure all IMAP processors are safe to run out of event loop #5325

Open
chibenwa opened this issue Nov 10, 2024 · 1 comment
Open

[CNB] Ensure all IMAP processors are safe to run out of event loop #5325

chibenwa opened this issue Nov 10, 2024 · 1 comment
Labels

Comments

@chibenwa
Copy link
Member

chibenwa commented Nov 10, 2024

IMAP reactive throttler might run requests out of the event loop underload

(to cap number of sync requests)

We need to ensure all our processors are safe to run out of the event loop

Setter on Scheduler to use in ImapServer + default to scheduler == Immediate?

(We need our test suite to accept IMAP commands to be executed both on and outside of the event loop)

@chibenwa
Copy link
Member Author

chibenwa commented Nov 10, 2024

Looks pretty bad actually: when executing from another scheduler IMAP sequential execution is no longer guarantied...

image

This is due to several variable to be computed when building the reactive chain and may be outdated when executing it... Maybe defering evaluation of those variables may be enough?

Commands pushing a line handler like AUTH, COMPRESS, IDLE & friends are also impacted. Fixing those in an open problem...

@chibenwa chibenwa added the bug label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant