Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate Guice module for OpenPaaS communication #1223

Closed
HoussemNasri opened this issue Oct 8, 2024 · 3 comments · Fixed by #1261
Closed

Create a separate Guice module for OpenPaaS communication #1223

HoussemNasri opened this issue Oct 8, 2024 · 3 comments · Fixed by #1261
Assignees

Comments

@HoussemNasri
Copy link
Member

HoussemNasri commented Oct 8, 2024

Description

We should have a separate Guice module for OpenPaaS communication to be able to inject custom RabbitMQ configuration that is specific to OpenPaas.

@HoussemNasri HoussemNasri changed the title Create a separate RabbitMQ module for OpenPaaS communication Create a separate Guice module for OpenPaaS communication Oct 8, 2024
@chibenwa chibenwa added the good first issue Good for newcomers label Oct 8, 2024
@chibenwa
Copy link
Member

chibenwa commented Oct 8, 2024

Depends on: #1215

Not really. IMO the too tasks are independant.

We can also write a OpenPaaSAmqpForwardAttribute mailet that is exactly AmqpForwardAttribute but configured using OpenPaaS configuration.

@chibenwa
Copy link
Member

chibenwa commented Oct 23, 2024

Let's create an openpaas.properties file:

# If ommitted default to the channelPool defined by RabbitMQ.properties
rabbitmq.url=amqp(s)://(user:password)@rabbit01:5843/theVhost(,amqp(s)://rabbit02:5843)
# Take the user, password, ssl setting and vhost for the first URL

contact.exchange.name=contact:added

openpaas.admin.username=...
openpaas.admin.password=...

So we create a RabbitMQChannelPool annotated with @Named("openpaas") from the above config and we fallback for the distributed tmail backend to the standard RabbitMQChannelPool.

@chibenwa
Copy link
Member

We decided with Houssem to not implement fallback for distributed-app to the main RabbitMQChannelPool.

We can live with 2 pools (we already live with 4 of them!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants