Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appgrid the right way #3260

Open
chibenwa opened this issue Nov 7, 2024 · 7 comments
Open

Appgrid the right way #3260

chibenwa opened this issue Nov 7, 2024 · 7 comments
Assignees
Labels

Comments

@chibenwa
Copy link
Member

chibenwa commented Nov 7, 2024

Summary

Because the app grid is currently hard coded we are better off removing it: #3258

Yet it is usefull to see 'related apps' to ease their instalation.

Backend offered a means for admins to hint users into chossing related apps using .well-known/linagora-ecosystem: linagora/tmail-backend#1289

  • For CNB / MU: he shall be advised Twake Sync
  • For Linagora: Twake Sync, Twake chat and why not LinShare
  • For TWP: Twake chat

When disabled show no mobile app grid.

When enabled show the mobile app grid based on it:

  • when clicked open the app if installed
  • and if not installed I am taken to the app store
@chibenwa
Copy link
Member Author

chibenwa commented Nov 7, 2024

Cf @hoangdat @guimard

@hoangdat
Copy link
Member

hoangdat commented Dec 3, 2024

@chibenwa
To be confirmed: .well-known/linagora-ecosystem only use for app grid mobile? Am I right?

@chibenwa
Copy link
Member Author

chibenwa commented Dec 3, 2024

To be confirmed: .well-known/linagora-ecosystem only use for app grid mobile? Am I right?

Yes. For web we can keep relying on static assets configuration in the Single Page Application I believe.

@hoangdat
Copy link
Member

hoangdat commented Dec 4, 2024

  • if an app existed in mobile-app, priority to show icon with link to mobile app
    • iOS vs Android
  • if an app not existed in mobile-app, show icon with link to web app (avoid duplication)
  • integration_test (jmap.properties)
    • verify open mobile app (link to store in case not existed)
    • verify open web app

@hoangdat
Copy link
Member

hoangdat commented Dec 4, 2024

Image

@hoangdat
Copy link
Member

hoangdat commented Dec 5, 2024

{
  "Twake Drive": {
  },
  "Twake Chat": {
  },
  "Twake Sync" {
  }
}

@dab246 dab246 self-assigned this Dec 6, 2024
@dab246
Copy link
Member

dab246 commented Dec 6, 2024

{
  "Twake Drive": {
  },
  "Twake Chat": {
  },
  "Twake Sync" {
  }
}

IMO, We don't need to change like that. Keeping the format of the returned BE intact, we can still parse it.

{
  "linShareApiUrl": "https://example.com/api",
  "linToApiUrl": "https://example.com/api",
  "linToApiKey": "apiKey",
  "twakeApiUrl": "https://example.com/api",
  "Twake Drive": {
    "appName": "Twake Drive",
    "logoURL": "https://xyz",
    "webLink": "https://abc"
  },
  "mobileApps": {
    "Twake Chat": {
      "appName": "Twake Chat",
      "logoURL": "https://xyz",
      "androidPackageId": "com.example.android",
      "iosUrlScheme": "app.scheme",
      "iosAppStoreLink": "itms-apps://itunes.apple.com/app"
    },
    "Twake Sync": {
      "appName": "Twake Sync",
      "logoURL": "https://xyz",
      "androidPackageId": "com.example.android"
    },
    "LinShare": {
      "appName": "LinShare",
      "logoURL": "https://xyz",
      "androidPackageId": "com.example.android",
      "iosUrlScheme": "app.scheme",
      "iosAppStoreLink": "itms-apps://itunes.apple.com/app"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants