Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Separate trash for the personal and shared drive #179

Closed
8 of 11 tasks
shepilov opened this issue Aug 28, 2023 · 0 comments · Fixed by #189
Closed
8 of 11 tasks

[Story] Separate trash for the personal and shared drive #179

shepilov opened this issue Aug 28, 2023 · 0 comments · Fixed by #189
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@shepilov
Copy link
Member

shepilov commented Aug 28, 2023

User story summary

Definition
UI/UX Design

Definition

We need to separate the trash into two different trashes

  • So you have trash from your personal drive. It’s straightforward and nothing special, you should see everything you or somebody who has access to the file deleted.
    But the key point is that you are the OWNER of the file.
  • For the shared drive, only if you have access to it.
    You should be able to view all the files, deleted from the shared drive if you had access to them before they were deleted.
    When you try to empty the trash, you can delete only files with the manage access

UI UX Design

In the trash page, we need to have a selector as in the breadcrumbs menu of the path. To choose the source from where the files were deleted :

  • My Drive
  • Shared Drive

Implementation

  • To the DriveItem model add type = "personal" | "shared" field
  • Also to the DriveItem use is_in_trash flag
  • Personal trash it will be all the files I'm a creator with the flag is_in_trash = true, shared trash we need to query all the files type == shared" and is_in_trash = true
  • Only for company admins can view and modify the "shared" trash
  • Don't forget to modify "type" flag when moving one folder from shared to my drive and vice versa
  • Also modify file creation, depending where you are creating a file in your personal drive or in the shared one
  • Restore from the trash function also should be updated
  • Update the current ones and wright new tests
  • Filter the current children and check that there is no files in the trash for the current "browse' query
  • Update the search, and filter files that are in the trash, or what is better, add the flag is_in_trash to the search index, and do not return files that are in trash
  • Update the logic for the widget with the size of the "Trash"
@shepilov shepilov added bug Something isn't working enhancement New feature or request labels Aug 28, 2023
@shepilov shepilov self-assigned this Aug 31, 2023
@MontaGhanmy MontaGhanmy linked a pull request Sep 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant