New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Can't download folders #742

Closed

tprudentova opened this issue Nov 26, 2024 · 1 comment · Fixed by #751

Assignees

Labels

bug

Milestone

v1.0.5-rc2+ - fin...

Collaborator

tprudentova commented Nov 26, 2024 •

edited

Loading

vv1.0.5rc6, drive.stg.lin-saas.com, Safari

Upload a folder
Try downloading it
Error

Screen.Recording.2024-11-26.at.11.44.40.mov

tprudentova added bug blocker labels

shepilov removed the blocker label

Collaborator

MontaGhanmy commented Nov 26, 2024

Currently, downloads in Safari are failing because the browser blocks new tabs triggered by the download process.

Potential Solutions:

Initiate the download within the same page instead of opening a new tab.
Implement a delay (e.g., setTimeout) to see if Safari allows the action.
Use an iframe?
Display a warning message asking users to change their settings to allow new tab downloads.

MontaGhanmy self-assigned this

MontaGhanmy linked a pull request

that will close this issue

🐛 Fix custom download file helper with safari fallback #751

Merged

MontaGhanmy closed this as completed in #751

ericlinagora added this to the v1.0.5-rc2+ milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment