Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pendingResponses to ServerMetrics #5666

Open
minwoox opened this issue May 8, 2024 · 2 comments · May be fixed by #5895
Open

Add pendingResponses to ServerMetrics #5666

minwoox opened this issue May 8, 2024 · 2 comments · May be fixed by #5895
Labels
improvement
Milestone
1.33.0

Comments

@minwoox
Copy link
Contributor

minwoox commented May 8, 2024

Currently, pendingResponses are managed in GracefulShutdownSupport. It would be beneficial to manage all server-related metrics within ServerMetrics, which will be added in #5627.

armeria/core/src/main/java/com/linecorp/armeria/server/Server.java

Lines 581 to 582 in 8678567

meterRegistry.gauge("armeria.server.pending.responses", gracefulShutdownSupport,
GracefulShutdownSupport::pendingResponses);

Side note: the difference between activeRequests and pendingResponses is that the pendingResponses does not include the request count for transient services.
@EunJungYoo
Copy link

I'm new to this project but I want to try on this issue. May I try on this issue? 🙏

@jrhee17
Copy link
Contributor

jrhee17 commented Aug 26, 2024

Sure, go for it 👍

@EunJungYoo EunJungYoo linked a pull request Sep 7, 2024 that will close this issue
Open
@jrhee17 jrhee17 added this to the 1.32.0 milestone Nov 5, 2024
@minwoox minwoox modified the milestones: 1.32.0, 1.33.0 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
1.33.0
Development

Successfully merging a pull request may close this issue.

Add pendingResponse to ServerMetrics EunJungYoo/armeria
3 participants
@jrhee17 @minwoox @EunJungYoo