Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics about PooledByteBufAllocator #2633

Closed
trustin opened this issue Mar 27, 2020 · 2 comments · Fixed by #5916
Closed

Add metrics about PooledByteBufAllocator #2633

trustin opened this issue Mar 27, 2020 · 2 comments · Fixed by #5916
Labels
new feature sprint Issues for OSS Sprint participants
Milestone
1.32.0

Comments

@trustin
Copy link
Member

trustin commented Mar 27, 2020 •
edited
Loading

Netty already exposes the metrics about its PooledByteBufAllocator. We could expose that information into Armeria's Micrometer metrics: https://github.com/netty/netty/blob/4.1/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocatorMetric.java
@ikhoon ikhoon added this to the 1.20.0 milestone Sep 2, 2022
@minwoox minwoox modified the milestones: 1.20.0, 1.21.0 Sep 29, 2022
@ikhoon ikhoon modified the milestones: 1.21.0, 1.22.0 Dec 12, 2022
@jrhee17 jrhee17 modified the milestones: 1.22.0, 1.23.0 Jan 27, 2023
@trustin trustin added the sprint Issues for OSS Sprint participants label Feb 16, 2023
@ikhoon ikhoon modified the milestones: 1.23.0, 1.24.0 Mar 15, 2023
@ikhoon ikhoon mentioned this issue Mar 22, 2023
Merged
@ikhoon ikhoon modified the milestones: 1.24.0, 1.25.0 Jun 2, 2023
@Bue-von-hon
Copy link
Contributor

May I continue with this issue?

@ikhoon
Copy link
Contributor

ikhoon commented Jun 15, 2023

Yes, please.

@jrhee17 jrhee17 modified the milestones: 1.25.0, 1.26.0 Jul 18, 2023
@minwoox minwoox modified the milestones: 1.26.0, 1.27.0 Oct 11, 2023
@ikhoon ikhoon modified the milestones: 1.27.0, 1.28.0 Jan 5, 2024
@jrhee17 jrhee17 modified the milestones: 1.28.0, 1.29.0 Mar 19, 2024
@minwoox minwoox modified the milestones: 1.29.0, 1.30.0 May 22, 2024
@ikhoon ikhoon modified the milestones: 1.30.0, 1.31.0 Aug 1, 2024
@Bue-von-hon Bue-von-hon mentioned this issue Sep 18, 2024
Merged
@jrhee17 jrhee17 removed this from the 1.31.0 milestone Nov 5, 2024
@jrhee17 jrhee17 added this to the 1.32.0 milestone Nov 5, 2024
ikhoon added a commit that referenced this issue Nov 25, 2024
@Bue-von-hon @ikhoon
Automatically register the metics of PooledByteBufAllocator.DEFAULT (…
7a6ddd7 
…#5916)

Motivation:
Add metrics related to PooledByteBufAllocator that is already exposed by
the netty.

Modifications:
- `NettyAllocatorMetrics` are registered when MoreMeterBinders is
initialized.


Result:

- Fixes #2633
- Armeria now automatically registers the metics of
`PooledByteBufAllocator.DEFAULT`.

---------

Co-authored-by: Ikhun Um <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature sprint Issues for OSS Sprint participants
Projects
None yet
Milestone
1.32.0
Development

Successfully merging a pull request may close this issue.

Automatically register the metics of PooledByteBufAllocator.DEFAULT Bue-von-hon/armeria
5 participants
@trustin @ikhoon @jrhee17 @minwoox @Bue-von-hon