Fill the stack trace of ResponseCompleteException when sampled
#5972
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nses = true` Motivation: `ResponseCompleteException` is considered a safe exception to clean up request resources. However, it would be a good idea to leave a stacktrace in case there is a bug in the implementation or the user wants to know how the error occurred. Modifications: - Create a new instance if `verboseResponse = true` and `ResponseCompletionException` is sampled by `verboseExceptionSampler` Result: You can now sees the stacktrace of `ResponseCompleteException` when `Flags.verboseResponse()` is true.
ikhoon
commented
Nov 7, 2024
core/src/main/java/com/linecorp/armeria/common/ResponseCompleteException.java
Outdated
Show resolved
Hide resolved
jrhee17
approved these changes
Nov 13, 2024
core/src/main/java/com/linecorp/armeria/common/ResponseCompleteException.java
Outdated
Show resolved
Hide resolved
ikhoon
changed the title
ResponseCompleteException when verboseResponses = trueResponseCompleteException when sampled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
ResponseCompleteExceptionis considered a safe exception for cleaning up request resources. However, it would be a good idea to leave a stack trace in case there is a bug in the implementation or the user wants to know how the error occurred.Discord thread: https://discord.com/channels/1087271586832318494/1087272728177942629/1303562249629073520
Modifications:
ResponseCompletionExceptionis sampled byverboseExceptionSamplerResult:
You can now sample the stack trace of
ResponseCompleteExceptionwithverboseExceptionSampler.