Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All methods on PlainEditor should also be available on PlainEditorDriver #200

Open
nicoburns opened this issue Dec 6, 2024 · 0 comments
Open

All methods on PlainEditor should also be available on PlainEditorDriver #200

nicoburns opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nicoburns
Copy link
Contributor

The new "driver" API makes sense from an efficiency point of view. But it is super annoying that some methods are only available on PlainEditorDriver and some are only available on PlainEditor. This can be worked around by doing driver.editor., but this is an unnecessary API wart.

I can see two possibilities:

  • We manually add all methods
  • We implement Deref and DerefMut for PlainEditorDriver
@nicoburns nicoburns added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nicoburns