Add upload_feed_document method #172
Conversation
Also, renamed `ResponseDecorator` to `Response` to make the interface more intuitive and keep the decorator pattern an internal detail.
|
Hi, thanks for the input! You’re right—#upload_feed_document isn’t part of the original Amazon API, so including it in the README was a mistake. I appreciate you retroactively adding it to the code; it’s logical to have it as a helper. But since I autogenerate the API files based on Amazon’s Open API files, these kinds of changes would be overwritten each time we regenerate. Maybe it's best to place this in a separate helper within the Feeds API file, allowing the generator to include that. I'll take a look at this when I have a moment, but feel free to jump in if you have time. P.S. I've fixed the response error in the documentation. |
harmonymjb
force-pushed
the
harmony/upload_feed_document_method
branch
from
df23b14
to
b5bb00c
Compare
This method has previously been mentioned in the README, but was not defined. This commit defines the method, with a slight change to take the user requested content-type, which must match due to the signed headers.
harmonymjb
force-pushed
the
harmony/upload_feed_document_method
branch
from
b5bb00c
to
0bf58cb
Compare
Thanks for explaining. |
|
This will require a tweak in the generator, but I'll go ahead and merge, thanks 🎃 |
|
My bad, no tweak required, thanks again! |
This method has previously been mentioned in the README, but was not defined. This PR defines the method, with an additional parameter to take the user requested content-type, which must match due to the signed headers.
Additionally, I noticed that API methods claim in their YARD docs to return a
Hashbut actually return anHTTP::Responsewhich must be called with.parseto access aHashversion of the response.I indicated this in line the functionality in the new YARD docs I wrote, but it may be useful to update existing occurrences elsewhere in the gem.