Set the failed http response in a custom attribute instead of cause
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#cause` in a custom error should return the expected class. This commit updates the custom value that is useful to store, the response, to use a specific name rather than overriding `#cause`’s behavior. Ruby documentation explains that the default expectation of #cause is that it will return either `an_exception` or `nil`. By setting an `HTTP::Response` to return from `#cause`, tools utilizing it may expect to send messages that may fail. https://ruby-doc.org/3.2.6/Exception.html#method-i-cause Specifically, I experienced a `NoMethodError: undefined method 'backtrace'` when an error occurred within `pry`.
|
Good point—merging now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#causein a custom error should return the expected class. This commit updates the custom value that is useful to store, the response, to use a specific name rather than overriding#cause’s behavior.Ruby documentation explains that the default expectation of
#causeis that it will return eitheran_exceptionornil. By setting anHTTP::Responseto return from#cause, tools utilizing it may expect to send messages that may fail.https://ruby-doc.org/3.2.6/Exception.html#method-i-cause
Specifically, I experienced a
NoMethodError: undefined method 'backtrace'when an error occurred withinpry.