-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible fixes from fork #35
Comments
Thank you for your help! I had undergone many changes in my life so I didn't update this repo regularly. So there changes are highly appreciated! I think 2 is really helpful for some applications but not for others. For example, sometimes people only want to work with phonemes so punctuations are not necessary for them. Could you make it optional? 3 and 4 are really, really helpful! Thank you so much!!! |
Firstly, I would like to express my gratitude for the development of such an excellent tool. During my testing using L2 Mandarin speech, it became clear that these speakers tend to speak more slowly, which often results in the insertion of false [SIL]. The modified script has shown to produce better results with this speech, but I am curious to know if there is a way to completely avoid the insertion of [SIL], particularly when it is inserted in the middle of one Chinese character, given this is a rare occurrence in Mandarin. |
@phliulei I think the best way is to specify a minimum silence duration, so anything shorter is ignored/treated as part of the previous phone. I mentioned this in point (4) above but I haven't had a chance to implement yet. |
Thanks for this great package! I forked the repo to tweak a few things to help my use case, and some of them might be useful to merge back into the master branch. I haven't submitted a PR because some of them might not be appropriate/desirable to merge, so I figured you could tell me which ones you want and I could clean up the code/add some tests if necessary and submit a PR then.
Fork is at https://github.com/nmfisher/charsiu
Changes are:
The text was updated successfully, but these errors were encountered: