diff --git a/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/BenchmarkConstants.java b/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/BenchmarkConstants.java
index a7e39dd49..7fc73b151 100644
--- a/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/BenchmarkConstants.java
+++ b/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/BenchmarkConstants.java
@@ -18,4 +18,9 @@ public class BenchmarkConstants {
* Size of the genreted AVRO Primitive Bytes
*/
public static final Integer BYTES_SIZE = 20;
+
+ /**
+ * Length of generated Float Array.
+ */
+ public static final Integer FLOAT_ARRAY_SIZE = 2500;
}
diff --git a/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/FloatArrayBenchmark.java b/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/FloatArrayBenchmark.java
new file mode 100644
index 000000000..6940f0d15
--- /dev/null
+++ b/avro-fastserde/src/jmh/java/com/linkedin/avro/fastserde/FloatArrayBenchmark.java
@@ -0,0 +1,132 @@
+package com.linkedin.avro.fastserde;
+
+import com.linkedin.avro.fastserde.generated.avro.FloatArrayBenchmarkSchema;
+import com.linkedin.avro.fastserde.generator.AvroRandomDataGenerator;
+import com.linkedin.avro.fastserde.micro.benchmark.AvroGenericSerializer;
+import com.linkedin.avroutil1.compatibility.AvroCompatibilityHelper;
+import java.io.ByteArrayInputStream;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericData;
+import org.apache.avro.generic.GenericDatumReader;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.io.BinaryDecoder;
+import org.apache.avro.io.DatumReader;
+import org.openjdk.jmh.annotations.Benchmark;
+import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Fork;
+import org.openjdk.jmh.annotations.Level;
+import org.openjdk.jmh.annotations.Measurement;
+import org.openjdk.jmh.annotations.Mode;
+import org.openjdk.jmh.annotations.OperationsPerInvocation;
+import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Scope;
+import org.openjdk.jmh.annotations.Setup;
+import org.openjdk.jmh.annotations.State;
+import org.openjdk.jmh.annotations.Warmup;
+import org.openjdk.jmh.infra.Blackhole;
+import org.openjdk.jmh.profile.GCProfiler;
+import org.openjdk.jmh.runner.Runner;
+import org.openjdk.jmh.runner.RunnerException;
+import org.openjdk.jmh.runner.options.OptionsBuilder;
+
+
+/**
+ * A benchmark that evaluates the performance of PrimitiveFloatList access
+ *
+ * To run this benchmark:
+ *
+ * ./gradlew :avro-fastserde:jmh -PUSE_AVRO_18
+ *
+ *
+ */
+@State(Scope.Benchmark)
+@BenchmarkMode(Mode.AverageTime)
+@OutputTimeUnit(TimeUnit.NANOSECONDS)
+@Fork(1)
+//@Fork(value = 1, jvmArgsAppend = {"-XX:+PrintGCDetails", "-Xms16g", "-Xmx16g"})
+//@Threads(10)
+@Warmup(iterations = 3)
+@Measurement(iterations = 3)
+public class FloatArrayBenchmark {
+ private static final int NUMBER_OF_OPERATIONS = 100_000;
+
+ private final Random random = new Random();;
+ private final Map properties = new HashMap<>();
+
+ private byte[] serializedBytes;
+ private GenericData.Record generatedRecord;
+
+ private final Schema benchmarkSchema = FloatArrayBenchmarkSchema.SCHEMA$;
+ private static AvroRandomDataGenerator generator;
+
+ private static DatumReader fastDeserializer;
+
+ public FloatArrayBenchmark() {
+ // load configuration parameters to avro data generator
+ properties.put(AvroRandomDataGenerator.ARRAY_LENGTH_PROP, BenchmarkConstants.FLOAT_ARRAY_SIZE);
+ generator = new AvroRandomDataGenerator(benchmarkSchema, random);
+ }
+
+ public static void main(String[] args) throws RunnerException {
+ org.openjdk.jmh.runner.options.Options opt = new OptionsBuilder()
+ .include(FastAvroSerdesBenchmark.class.getSimpleName())
+ .addProfiler(GCProfiler.class)
+ .build();
+ new Runner(opt).run();
+ }
+
+ public byte[] serializeGeneratedRecord(GenericData.Record generatedRecord) throws Exception {
+ AvroGenericSerializer serializer = new AvroGenericSerializer(benchmarkSchema);
+ return serializer.serialize(generatedRecord);
+ }
+
+ @Setup(Level.Trial)
+ public void prepare() throws Exception {
+ // generate avro record and bytes data
+ generatedRecord = (GenericData.Record) generator.generate(properties);
+ serializedBytes = serializeGeneratedRecord(generatedRecord);
+
+ fastDeserializer = new FastGenericDatumReader<>(benchmarkSchema);
+ }
+
+ @Benchmark
+ @OperationsPerInvocation(NUMBER_OF_OPERATIONS)
+ public void testFastAvroDeserializationAccess1(Blackhole bh) throws Exception {
+ testFastFloatArrayDeserialization(fastDeserializer, bh, 1);
+ }
+
+ @Benchmark
+ @OperationsPerInvocation(NUMBER_OF_OPERATIONS)
+ public void testFastAvroDeserializationAccess8(Blackhole bh) throws Exception {
+ testFastFloatArrayDeserialization(fastDeserializer, bh, 8);
+ }
+
+ @Benchmark
+ @OperationsPerInvocation(NUMBER_OF_OPERATIONS)
+ public void testFastAvroDeserializationAccess16(Blackhole bh) throws Exception {
+ testFastFloatArrayDeserialization(fastDeserializer, bh, 16);
+ }
+
+ private void testFastFloatArrayDeserialization(DatumReader datumReader, Blackhole bh, int numElementAccess) throws Exception {
+ GenericRecord record = null;
+ BinaryDecoder decoder = AvroCompatibilityHelper.newBinaryDecoder(serializedBytes);
+ for (int i = 0; i < NUMBER_OF_OPERATIONS; i++) {
+ float w = 0;
+ decoder = AvroCompatibilityHelper.newBinaryDecoder(new ByteArrayInputStream(serializedBytes), false, decoder);
+ record = datumReader.read(record, decoder);
+ if (numElementAccess > 0) {
+ List list = (List)record.get(0);
+ for (int j = 0; j < list.size(); j += numElementAccess) {
+ w += list.get(j);
+ }
+ }
+ bh.consume(record);
+ bh.consume(w);
+ }
+ }
+}
diff --git a/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/ByteBufferBackedPrimitiveFloatList.java b/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/ByteBufferBackedPrimitiveFloatList.java
index b84be7e8a..5dfcff270 100644
--- a/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/ByteBufferBackedPrimitiveFloatList.java
+++ b/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/ByteBufferBackedPrimitiveFloatList.java
@@ -185,8 +185,10 @@ public float getPrimitive(int i) {
if (i >= size) {
throw new IndexOutOfBoundsException("Index " + i + " out of bounds.");
}
- cacheFromByteBuffer();
- return elements[i];
+ if (isCached) {
+ return elements[i];
+ }
+ return byteBuffer.getElement(i);
}
@Override
diff --git a/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/CompositeByteBuffer.java b/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/CompositeByteBuffer.java
index 690e07320..9b8f0a102 100644
--- a/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/CompositeByteBuffer.java
+++ b/avro-fastserde/src/main/java/com/linkedin/avro/fastserde/CompositeByteBuffer.java
@@ -43,6 +43,24 @@ public void setByteBufferCount(int count) {
byteBufferCount = count;
}
+ public float getElement(int i) {
+ int index = i * 4;
+ // most common case:
+ if (byteBufferCount == 1) {
+ return byteBuffers.get(0).getFloat(index);
+ }
+
+ int k = 0, size = 0;
+ // find which byteBuffer holds the i-th item
+ while (index >= size) {
+ size += byteBuffers.get(k++).limit();
+ }
+ k--;
+ // find the index on the byte buffer
+ int j = i - (size - byteBuffers.get(k).limit());
+ return byteBuffers.get(k).getFloat(j);
+ }
+
public void setArray(float[] array) {
int k = 0;
for (int i = 0; i < byteBufferCount; i++) {
diff --git a/avro-fastserde/src/test/avro/floatArrayBenchmarkSchema.avsc b/avro-fastserde/src/test/avro/floatArrayBenchmarkSchema.avsc
new file mode 100644
index 000000000..b22725f9e
--- /dev/null
+++ b/avro-fastserde/src/test/avro/floatArrayBenchmarkSchema.avsc
@@ -0,0 +1,15 @@
+{
+ "type": "record",
+ "name": "FloatArrayBenchmarkSchema",
+ "namespace": "com.linkedin.avro.fastserde.generated.avro",
+ "doc": "JMH micro benchmark schema template",
+ "fields": [
+ {
+ "name": "testArray",
+ "type": {
+ "type": "array",
+ "items": "float"
+ }
+ }
+ ]
+}
\ No newline at end of file