Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are flaky #49

Open
asakusuma opened this issue May 30, 2017 · 0 comments
Open

Tests are flaky #49

asakusuma opened this issue May 30, 2017 · 0 comments
Assignees
@SparshithNR

Comments

@asakusuma
Copy link
Contributor

The test are very dependent on nightmare.wait(). The asynchronous nature of the implementation makes things hard to test, but there are some tests that are flaky on local machines. A few potential fixes:

Improve timing issues

  1. Introduce IMPRESSION_THRESHOLD and RAF_THRESHOLD constants so that it's not a pain to change all the test wait() values every time we want to change thresholds or tweak global timing variables.
  2. Increase the default impression threshold for tests
  3. Increase RAF/general sync padding

Try another headless browser

Like headless chrome. We would just need to re-implement SpanielContext and Context
SparshithNR pushed a commit to SparshithNR/spaniel that referenced this issue Jun 1, 2017
WIP:linkedin#49
fc0c945 
linkedin#49
@SparshithNR SparshithNR mentioned this issue Jun 1, 2017
Merged
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 1, 2017
@SparshithNR
WIP:linkedin#49
67487b4 
linkedin#49
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 1, 2017
@SparshithNR
WIP:linkedin#49
81808d5 
linkedin#49
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 2, 2017
@SparshithNR
WIP:linkedin#49
952fbd8 
linkedin#49
SparshithNR pushed a commit to SparshithNR/spaniel that referenced this issue Jun 2, 2017
@SparshithNR
WIP:linkedin#49
4b4bd77 
linkedin#49

WIP:linkedin#49
linkedin#49

WIP:linkedin#49
linkedin#49
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 2, 2017
@SparshithNR
linkedin#49
716f66b 
linkedin#49 : Fix: Added a small wait time after each scroll
SparshithNR pushed a commit to SparshithNR/spaniel that referenced this issue Jun 2, 2017
@SparshithNR
WIP:linkedin#49
dc03010 
linkedin#49

WIP:linkedin#49
linkedin#49

WIP:linkedin#49
linkedin#49

linkedin#49 : Fix: Added a small wait time after each scroll
SparshithNR pushed a commit to SparshithNR/spaniel that referenced this issue Jun 2, 2017
@SparshithNR
linkedin#49
bf5f5ea 
linkedin#49 : Fix: Added a small wait time after each scroll
asakusuma pushed a commit that referenced this issue Jun 2, 2017
@asakusuma
#49
c9443a1 
#49 : Fix: Added a small wait time after each scroll
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 30, 2017
@SparshithNR
WIP linkedin#49:
e9cbcb4 
linkedin#49 Clean up work
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 3, 2017
@SparshithNR
WIP linkedin#49:
586ea83 
    linkedin#49 Modified tests to respect the threshold time and addressed review comment
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 10, 2017
@SparshithNR
WIP linkedin#49:
5cdb5ec 
linkedin#49 Impression complete event spec making it to use impression threshold
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 31, 2017
@SparshithNR
WIP linkedin#49:
c4fa1b4 
linkedin#49 Clean up work
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 31, 2017
@SparshithNR
WIP linkedin#49:
e41f980 
    linkedin#49 Modified tests to respect the threshold time and addressed review comment
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 31, 2017
@SparshithNR
WIP linkedin#49:
b02dac8 
linkedin#49 Impression complete event spec making it to use impression threshold
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Aug 1, 2017
@SparshithNR
49:
29b660d 
linkedin#49 Making test deterministic
asakusuma pushed a commit that referenced this issue Aug 4, 2017
@SparshithNR @asakusuma
49:
38e32d2 
#49 Making test deterministic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SparshithNR SparshithNR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asakusuma @SparshithNR