Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce requestAnimationFrame polling #52

Open
2 of 3 tasks
asakusuma opened this issue Jun 1, 2017 · 0 comments
Open
2 of 3 tasks

Reduce requestAnimationFrame polling #52

asakusuma opened this issue Jun 1, 2017 · 0 comments
Assignees
@SparshithNR
Labels
performance

Comments

@asakusuma
Copy link
Contributor

asakusuma commented Jun 1, 2017 •
edited
Loading

  • Add a short gap (< 50ms) between requestAnimationFrame polls
  • Only polyfill IntersectionObserver when necessary
  • Via a host interface, provide a higher-order function that is passed a function that gets called anytime the DOM is updated. This guarantees that viewport status changes must occur either after this function call, on scroll, or on resize. Thus we don't have to poll and can use passive listeners on scroll and resize.
@asakusuma asakusuma assigned asakusuma and SparshithNR and unassigned asakusuma Jun 20, 2017
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 22, 2017
@SparshithNR
linkedin#50
d9bc1f0 
linkedin#52: first phase of imporvement, skipped three iteration of the rFA
@SparshithNR SparshithNR mentioned this issue Jun 22, 2017
Merged
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 23, 2017
@SparshithNR
linkedin#52
9d54d96 
linkedin#52 : Modified wait time since we are skipping few rFA cycles. So test are breaking. Still need to fix the large time dependency.
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 23, 2017
@SparshithNR
linkedin#52
43fb172 
linkedin#52:  Adding constant
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 24, 2017
@SparshithNR
linkedin#52
3983438 
    linkedin#52:  Adding test SKIP_CYCLE constant
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 24, 2017
@SparshithNR
linkedin#52
f74a1e5 
    linkedin#52:  Adding test SKIP_CYCLE constant
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 27, 2017
@SparshithNR
linkedin#52
b9ed1d5 
linkedin#52:  Changed timeout value
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 27, 2017
@SparshithNR
linkedin#52
f8a5b33 
linkedin#52:  Changed accuracy to be +-16ms*skip_cycle
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 27, 2017
@SparshithNR
linkedin#52
8398fff 
linkedin#52:  Changed accuracy to be +-16ms*skip_cycle
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 27, 2017
@SparshithNR
linkedin#52
ca399b2 
linkedin#52:  Changed name of constant and value to avoid confusion
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 27, 2017
@SparshithNR
linkedin#52
da8681e 
linkedin#52:  addedm few extra time to get oberserver take effect.
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jun 28, 2017
@SparshithNR
linkedin#52: first phase of imporvement, skipped three iteration of t…
18022e5 
…he rFA
asakusuma pushed a commit that referenced this issue Jun 28, 2017
@SparshithNR @asakusuma
#52: first phase of imporvement, skipped three iteration of the rFA
ef26153
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 17, 2017
@SparshithNR
WIP linkedin#52
4099e78 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 18, 2017
@SparshithNR
WIP linkedin#52
e2d21d1 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 18, 2017
@SparshithNR
WIP linkedin#52
22a02ca 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 18, 2017
@SparshithNR
WIP linkedin#52
468ebbc 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 19, 2017
@SparshithNR
WIP linkedin#52
b0d95ff 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 19, 2017
@SparshithNR
WIP linkedin#52
710f873 
linkedin#52 Using native IntersectionObserver if browser support
SparshithNR added a commit to SparshithNR/spaniel that referenced this issue Jul 19, 2017
@SparshithNR
linkedin#52 Allow spaniel to use native IntersectionObserver if brows…
cf91f19 
…er supports
asakusuma pushed a commit that referenced this issue Jul 19, 2017
@SparshithNR @asakusuma
#52 Allow spaniel to use native IntersectionObserver if browser supports
ab6a522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SparshithNR SparshithNR

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asakusuma @SparshithNR