Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow improvement #45

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Workflow improvement #45

merged 5 commits into from
Dec 21, 2023

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Dec 17, 2023 •
edited
Loading

Proposed changes

  • Reduces overlapping triggers (pull_request/pull_request_target).
  • Updates action versions.
  • Remove global triggers (on any push) that would trigger all pipelines all the time. It's a high number of redundant and wasteful work.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types

Please indicate if your PR introduces a breaking change

  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

@mhitza
chore: simplify 10-review.yaml workflow
aa1b4e5 
Keep only the pull_request_target trigger, as it keeps the workflow
actionable as oppossed to push/dispatch events.

Remove commented out actions.

Upate to latest versiion of webiny/actiion-conventional-commit
@mhitza
chore: simplify/update 30-release-and-build workflow
0372396 
Update the following actions to their latest versions:
 - with no changes required
   - docker/setup-qemu-action
   - docker/setup-buildx-action
   - docker/metadata-action
   - docker/login-action
   - docker/build-push-action
 - with changes
   - codfish/semantic-release-action

Inline the repostitory name variable within the generated .releaserc
file instead of replacing it afterwards via sed
@mhitza
chore: fix typo in 40-helm.yaml
480b45e
@mhitza
chore: update actions in 50-security.yaml
399bc86
@mhitza
chore: update 00-start.yaml
6632537 
Prevent it from starting up on push/pull-request actions on a given
repository, and leave in the option to trigger it manually or from
another workflow.
@mhitza mhitza marked this pull request as ready for review December 21, 2023 20:59
@mhitza mhitza requested a review from joostfaassen as a code owner December 21, 2023 20:59
@mhitza mhitza merged commit 938ecda into linkorb:main Dec 21, 2023
2 checks passed
@mhitza mhitza deleted the workflow-improvement branch December 21, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joostfaassen joostfaassen Awaiting requested review from joostfaassen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhitza