Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot merge #8279 #54

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix dependabot merge #8279 #54

merged 1 commit into from
Jan 11, 2024

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Dec 30, 2023

The --auto flag, according to the docs, merges a PR automatically when
the PR passes branch protection rules, or has requirements checks
enabled.

Example error message from some repositories:

GraphQL: Pull request Protected branch rules not configured for this
branch (enablePullRequestAutoMerge)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types

Please indicate if your PR introduces a breaking change

  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

The --auto flag, according to the docs, merges a PR automatically when
the PR passes branch protection rules, or has requirements checks
enabled.

Example error message from some repositories:

```
GraphQL: Pull request Protected branch rules not configured for this
branch (enablePullRequestAutoMerge)
```

This flag proved inconsistent in testing, and conflicting official
documentation in certain places. Merges got blocked on projects, and
through testing merging worked without the --auto flag.
@mhitza mhitza marked this pull request as ready for review January 11, 2024 15:46
@mhitza mhitza requested a review from joostfaassen as a code owner January 11, 2024 15:46
@mhitza mhitza merged commit 754cccd into linkorb:main Jan 11, 2024
2 checks passed
@mhitza mhitza deleted the fix-dependabot-merge-8279 branch January 11, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant