Merge pull request #54 from linode-obs/fix/update-logging

cxdy · web-flow · commit ce4937a1dc74 · 2025-02-12T11:19:38.000-08:00
fix: only log when nagios.com is unreachable
diff --git a/nagios_exporter.go b/nagios_exporter.go
@@ -472,10 +472,10 @@ func (e *Exporter) QueryAPIsAndUpdateMetrics(ch chan<- prometheus.Metric, sslVer
 				updateAvailable, prometheus.GaugeValue, updateMetric,
 				// updateMetric 0 = no update, updateMetric 1 = update available
 			)
+		} else {
+			log.Warn("Nagios version wasn't found, not updating `nagios_update_available_info` metric")
 		}
 
-		log.Warn("Nagios version wasn't found, not updating `nagios_update_available_info` metric")
-
 	} else { // user did not want to compare nagios versions externally so just say there aren't any updates (0)
 		ch <- prometheus.MustNewConstMetric(
 			updateAvailable, prometheus.GaugeValue, 0,

Original file line number	Diff line number	Diff line change
`@@ -472,10 +472,10 @@ func (e *Exporter) QueryAPIsAndUpdateMetrics(ch chan<- prometheus.Metric, sslVer`
`472`	`472`	`updateAvailable, prometheus.GaugeValue, updateMetric,`
`473`	`473`	`// updateMetric 0 = no update, updateMetric 1 = update available`
`474`	`474`	`)`
	`475`	`+ } else {`
	`476`	+ log.Warn("Nagios version wasn't found, not updating `nagios_update_available_info` metric")
`475`	`477`	`}`
`476`	`478`
`477`		- log.Warn("Nagios version wasn't found, not updating `nagios_update_available_info` metric")
`478`		`-`
`479`	`479`	`} else { // user did not want to compare nagios versions externally so just say there aren't any updates (0)`
`480`	`480`	`ch <- prometheus.MustNewConstMetric(`
`481`	`481`	`updateAvailable, prometheus.GaugeValue, 0,`