upcoming: [M3-8840] - Add Cluster Type selection to LKE Create Cluster flow #11322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
requested review from
AzureLatte,
carrillo-erik,
cpathipa and
hana-akamai
and removed request for
a team
mjac0bs
commented
Nov 25, 2024
| @@ -87,6 +88,11 @@ export interface SelectionCardProps { | |||
| * Optional text to set in a tooltip when hovering over the card. | |||
| */ | |||
| tooltip?: JSX.Element | string; | |||
| /** | |||
There was a problem hiding this comment.
Added this prop to be able to control the placement of the tooltip - it was covering the helper text and we could avoid that by placing elsewhere.
| @@ -51,11 +51,10 @@ export const StyledFieldWithDocsStack = styled(Stack, { | |||
| })); | |||
|
|
|||
| export const StyledDocsLinkContainer = styled(Box, { | |||
| label: 'StyledRegionSelectStack', | |||
| label: 'StyledDocsLinkContainer', | |||
There was a problem hiding this comment.
Changes to use the same styling for both the cluster type and DC pricing docs links.
| @@ -191,29 +191,34 @@ export const getLatestVersion = ( | |||
| * Hook to determine if the LKE-Enterprise feature should be visible to the user. | |||
| * Based on the user's account capability and the feature flag. | |||
| * | |||
| * @returns {boolean, boolean} - Whether the LKE-Enterprise feature is enabled for the current user in LA and GA, respectively. | |||
| * @returns {boolean, boolean, boolean, boolean} - Whether the LKE-Enterprise flags are enabled for LA/GA and whether feature is enabled for LA/GA (flags + account capability). | |||
There was a problem hiding this comment.
Changes were to account for the fact that the Create flow shows the Cluster Type section as long as the LD feature flag is on; it does not depend on account capability. The reason for this is to show all customers what is potentially available, even if not currently on their contract.
|
Coverage Report: ✅ |
hana-akamai
reviewed
Nov 26, 2024
Cloud Manager UI test results🔺 3 failing tests on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts" |
|||||||||||||||||||||||
hana-akamai
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
We want to allow users the ability to create an LKE-Enterprise cluster in the create flow.
Changes 🔄
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅