test: [M3-8608] - Cypress test for restricted user Image non-empty landing page #11335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasyed-akamai
added
the
e2e
| cy.wait('@getImages'); | ||
| cy.url().should('endWith', '/images'); | ||
|
|
||
| cy.contains('Custom Images') |
There was a problem hiding this comment.
To make the code more robust, search for "Custom Images" using the h3 tag and use .closest() to locate the parent div instead of relying on the div hierarchy. This approach avoids potential failures caused by changes in the div structure.
Suggested change
cy.contains('h3', 'Custom Images')
.closest('div[data-qa-paper="true"]')
.find('[role="table"]')
.should('exist')
.as('customImageTable');
| .should('exist') | ||
| .as('customImageTable'); | ||
|
|
||
| cy.contains('Recovery Images') |
There was a problem hiding this comment.
same as above
cy.contains('h3', 'Recovery Images')
.closest('div[data-qa-paper="true"]')
.find('[role="table"]')
.should('exist')
.as('recoveryImageTable');
| .find('tbody tr') | ||
| .should('have.length', mockImages.length); | ||
|
|
||
| function checkActionMenu(tableAlias: string) { |
There was a problem hiding this comment.
To enhance the readability of the test, I recommend moving this function outside the test block. This will help reduce nesting and make the test easier to follow.
Cloud Manager UI test results🎉 463 passing tests on test run #4 ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added cypress test for restricted user Image non-Empty landing page
Changes 🔄
Added below cypress tests under in spec file -
cypress/e2e/core/images/images-non-empty-landing-page.spec.ts2. Navigate to images page with restricted user - https://cloud.linode.com/images
2. Validate that "Create Image" button is disabled.
3. Validate the tooltip warning message "You don't have permissions to create Images. Please contact your account administrator to request the necessary permissions."
4. Validate the action menu items are disabled for restricted user except "Deploy to New Linode"
How to test 🧪
yarn cy:run -s cypress/e2e/core/images/images-non-empty-landing-page.spec.tsVerification steps
When test executed using this command
yarn cy:run -s cypress/e2e/core/images/images-non-empty-landing-page.spec.tsall tests should pass successfully.As an Author I have considered 🤔
Check all that apply