refactor: [M3-8986] - Refactor VPCEditDrawer and SubnetEditDrawer to use react-hook-form
#11393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
abailly-akamai and
harsh-akamai
and removed request for
a team
coliu-akamai
commented
Dec 10, 2024
Comment on lines
116
to
+123
| .max(64, LABEL_MESSAGE) | ||
| .matches(/[a-zA-Z0-9-]+/, LABEL_REQUIREMENTS); | ||
| .matches(/^[a-zA-Z0-9-]*$/, LABEL_REQUIREMENTS); | ||
|
|
||
| export const updateVPCSchema = object({ | ||
| label: labelValidation.notRequired(), | ||
| description: string().notRequired(), | ||
| label: labelValidation, | ||
| description: string(), |
There was a problem hiding this comment.
- fixes regex so that it checks against all characters, not just the first one, for non letter/number characters (besides dashes)
- removed the
notRequired()since that led to type errors when using the schema:Type 'Maybe<string | undefined>' is not assignable to type 'string | undefined'. Type 'null' is not assignable to type 'string | undefined'.Removing this makes the schema align better with the payload too, so I don't think this will be an issue
|
adding wait to merge label for this - some VPCCreate tests are currently failing due to validation punctuation changes, planning to merge #11357 first and then rebase this and fix any conflicts/tests that emerge after (still ready for review tho) |
abailly-akamai
approved these changes
Dec 11, 2024
coliu-akamai
force-pushed
the
update-small-vpc-drawers
branch
from
1d9c73f to
95e80e3
Compare
coliu-akamai
force-pushed
the
update-small-vpc-drawers
branch
from
95e80e3 to
d4f1e72
Compare
coliu-akamai
added
Add'tl Approval Needed
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 469 passing tests on test run #5 ↗︎
|
harsh-akamai
approved these changes
Dec 11, 2024
harsh-akamai
added
Approved
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 31m 02s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
469
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅