Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SLES15 enablement, HAE detection #192

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

marcelmamula
Copy link
Contributor

Enhancement: Adds additional steps for SLES15 enablement:

  • High Availability Extension detection
  • Package list updated to remove SLES4SAP specific package
  • Cluster destroy adjusted to avoid failure when corosync-qdevice was not present
  • Removed logd check, because it is part of cluster packages and it should not be checked before packages are installed on SLES15
  • Added gather facts for NIC for corosync template.

Additionally main.yml was reordered to allow variable checks before package installation.

Readme was updated to note higher Service Pack requirement for both SLES and SLES4SAP, because of detected dependency on pattern patterns-ha-ha_sles, which failed to install using package module because of samba client version mismatch.

Reason: Adding coverage for SLES15 after cluster deployment verification.

Result: Testing completed on both SLES4SAP 15 SP5 and SLES15 SP5 with HA, cluster creation and destroy are working.

Issue Tracker Tickets (Jira or BZ if any):

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82c3964) 50.54% compared to head (89ad067) 76.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #192       +/-   ##
===========================================
+ Coverage   50.54%   76.79%   +26.24%     
===========================================
  Files           1        3        +2     
  Lines          91      181       +90     
  Branches       12       12               
===========================================
+ Hits           46      139       +93     
+ Misses         45       42        -3     
Flag Coverage Δ
sanity 50.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek
Copy link
Member

[citest]

tasks/main.yml Outdated Show resolved Hide resolved
tasks/shell_crmsh/cluster-destroy-crm.yml Show resolved Hide resolved
@tomjelinek
Copy link
Member

[citest]

@richm richm merged commit b92ac74 into linux-system-roles:main Feb 15, 2024
30 of 33 checks passed
@marcelmamula marcelmamula deleted the suse branch March 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants