Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: easily install cloud agents #194

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

tomjelinek
Copy link
Member

Enhancement:
Make it easier to install agents for cloud environments.

Reason:
The agents are not installed by default. Even though users can install them by other means, we want to provide a variable to install them easily.

Result:
Setting ha_cluster_install_cloud_agents variable to true installs cloud agents.

Issue Tracker Tickets (Jira or BZ if any):
RHEL-27186
#185

@tomjelinek tomjelinek requested a review from richm as a code owner February 28, 2024 12:55
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (c1563c6) to head (5ae143e).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #194       +/-   ##
===========================================
+ Coverage   50.54%   76.79%   +26.24%     
===========================================
  Files           1        3        +2     
  Lines          91      181       +90     
  Branches       12       12               
===========================================
+ Hits           46      139       +93     
+ Misses         45       42        -3     
Flag Coverage Δ
sanity 50.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek
Copy link
Member Author

[citest]

@tomjelinek tomjelinek marked this pull request as draft February 28, 2024 13:16
@tomjelinek tomjelinek marked this pull request as ready for review February 28, 2024 14:13
@tomjelinek
Copy link
Member Author

[citest]

@spetrosi
Copy link
Collaborator

[citest]

1 similar comment
@richm
Copy link
Contributor

richm commented Feb 28, 2024

[citest]

@tomjelinek
Copy link
Member Author

[citest]

@richm richm merged commit 620f0dd into linux-system-roles:main Mar 4, 2024
27 of 30 checks passed
@tomjelinek tomjelinek deleted the cloud-agents branch March 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants