Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update constraints commands syntax for pcs-0.12 #245

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tomjelinek
Copy link
Member

Enhancement:
Update the role to pcs-0.12 command syntax

Reason:
New version of pcs brings updated syntax of some commands. Previous syntax is deprecated but it still works. It will be dropped eventually, though, and the role should be ready for that.

Result:
Role uses new pcs syntax if new enough pcs is available.

Issue Tracker Tickets (Jira or BZ if any):
https://issues.redhat.com/browse/RHEL-45303

@tomjelinek tomjelinek requested a review from richm as a code owner December 6, 2024 14:27
@tomjelinek
Copy link
Member Author

[citest]

@richm richm merged commit eb3bc2b into linux-system-roles:main Dec 9, 2024
17 of 24 checks passed
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4be7b3c) to head (0a78554).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #245       +/-   ##
=========================================
- Coverage   78.94%      0   -78.95%     
=========================================
  Files           6      0        -6     
  Lines         361      0      -361     
=========================================
- Hits          285      0      -285     
+ Misses         76      0       -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek tomjelinek deleted the pcs-0.12-syntax branch December 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants