From 6140cd1767d4b4a2a11efbaac37bc9d167d8a5d1 Mon Sep 17 00:00:00 2001 From: Kevin Langman Date: Fri, 4 Oct 2024 10:51:50 -0400 Subject: [PATCH] [CinnamonBurnMyWindows@klangman] Fix for forcing Cinnamon effects on The ShouldAnimateManager was failing to call the original Cinnamon _shouldAnimate() function for cases where the event context was not one that the manager is currently interested in. This meant that some Cinnamon's effects like maximize and restore would apply even if the Cinnamon Effects settings had them disabled. --- CinnamonBurnMyWindows@klangman/CHANGELOG.md | 4 ++++ CinnamonBurnMyWindows@klangman/README.md | 2 +- .../6.2/ShouldAnimateManager.js | 3 +-- .../files/CinnamonBurnMyWindows@klangman/metadata.json | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/CinnamonBurnMyWindows@klangman/CHANGELOG.md b/CinnamonBurnMyWindows@klangman/CHANGELOG.md index 2d7b0853..20cfdd78 100644 --- a/CinnamonBurnMyWindows@klangman/CHANGELOG.md +++ b/CinnamonBurnMyWindows@klangman/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## 0.9.4 + +* Fixed an issue that could interfere with other Cinnamon effects by returning true from Cinnamon's _shouldAnimate(). Some effects like Restore and Manximize might occur even when they were disabled in the Cinnamon Effects setting application. Also some BurnMyWindows effect could happen on events other than window open/close events (but I didn't ever see this occur myself). + ## 0.9.3 * Fix Randomized effects so that when the Doom effect is enabled under "Random Effects" it can actually be randomly selected for use diff --git a/CinnamonBurnMyWindows@klangman/README.md b/CinnamonBurnMyWindows@klangman/README.md index db3c9d38..86f04d02 100644 --- a/CinnamonBurnMyWindows@klangman/README.md +++ b/CinnamonBurnMyWindows@klangman/README.md @@ -27,7 +27,7 @@ The Doom open effect seems to finish animating at a noticeably lower position th All open window effects seem to animate in a location that is one pixel off the windows real location. This causes a very small (nearly unnoticeable) jump of the window after the animation has finished. The only exception is "Doom", which as stated above has a more pronounced jump. -The window shadows are not part of the animation and therefore they suddenly appear right after the animation completes. +The window shadows are not part of the animation and therefore they suddenly appear or disappear right after or before the animation. ### Currently these effects are working in Cinnamon: diff --git a/CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/6.2/ShouldAnimateManager.js b/CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/6.2/ShouldAnimateManager.js index 8b051154..15e2b0b6 100644 --- a/CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/6.2/ShouldAnimateManager.js +++ b/CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/6.2/ShouldAnimateManager.js @@ -68,7 +68,6 @@ class ShouldAnimateManager { } disconnect() { - log( "in disconnect" ); for (let i=0 ; i