-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Update get-ip-from-fritzbox script #74
Comments
I'm confused as to what you are asking us to do. We build their latest releases. When they put out a release with that commit, it will be in the image. |
Did you check th elink to the github repository? This shows the modified script:
https://github.com/ddclient/ddclient/blob/master/sample-get-ip-from-fritzbox
It now contains the following code solving my issue:
# Set default hostname to connect to the FritzBox
: ${FRITZ_BOX_HOSTNAME:=fritz.box}
curl -s -H 'Content-Type: text/xml; charset="utf-8"' \
-H 'SOAPAction: urn:schemas-upnp-org:service:WANIPConnection:1#GetExternalIPAddress' \
-d '<?xml version="1.0" encoding="utf-8"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/" s:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/"> <s:Body> <u:GetExternalIPAddress xmlns:u="urn:schemas-upnp-org:service:WANIPConnection:1" /></s:Body></s:Envelope>' \
"http://$FRITZ_BOX_HOSTNAME:49000/igdupnp/control/WANIPConn1" | \ grep -Eo '\<[[:digit:]]{1,3}(\.[[:digit:]]{1,3}){3}\>'
Viele Grüße / Kind regards
Kalvalax
…------- Original Message -------
aptalca ***@***.***> schrieb am Freitag, 29. September 2023 um 00:20:
I'm confused as to what you are asking us to do. We build their latest releases. When they put out a release with that commit, it will be in the image.
—
Reply to this email directly, [view it on GitHub](#74 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AXCRZGXN3EBNMYJFUIAYTUDX4XZ2FANCNFSM6AAAAAA5LTMPNY).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
They haven't cut a release since that was added. It'll be in our container once they cut a release. |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue is locked due to inactivity |
Is this a new feature request?
Wanted change
The updated sample-get-ip-from-fritzbox script from ddclient/ddclient now can pass the ip/hostname of the fritzbox to use the script also when 'fritz.box' can't be resolved by using the optional environment variable FRITZ_BOX_HOSTNAME.
Reason for change
this image can't be used if fritz.box vcan_t be resolved.
Proposed code change
The changed script can be found here:
https://github.com/ddclient/ddclient/blob/master/sample-get-ip-from-fritzbox
The text was updated successfully, but these errors were encountered: