Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update get-ip-from-fritzbox script #74

Closed
1 task done
Kalvalax opened this issue Sep 28, 2023 · 5 comments
Closed
1 task done

[FEAT] Update get-ip-from-fritzbox script #74

Kalvalax opened this issue Sep 28, 2023 · 5 comments

Comments

@Kalvalax
Copy link

Is this a new feature request?

  • I have searched the existing issues

Wanted change

The updated sample-get-ip-from-fritzbox script from ddclient/ddclient now can pass the ip/hostname of the fritzbox to use the script also when 'fritz.box' can't be resolved by using the optional environment variable FRITZ_BOX_HOSTNAME.

Reason for change

this image can't be used if fritz.box vcan_t be resolved.

Proposed code change

The changed script can be found here:
https://github.com/ddclient/ddclient/blob/master/sample-get-ip-from-fritzbox

@aptalca
Copy link
Member

aptalca commented Sep 28, 2023

I'm confused as to what you are asking us to do. We build their latest releases. When they put out a release with that commit, it will be in the image.

@Kalvalax
Copy link
Author

Kalvalax commented Sep 28, 2023 via email

@j0nnymoe
Copy link
Member

They haven't cut a release since that was added. It'll be in our container once they cut a release.

@LinuxServer-CI
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@LinuxServer-CI LinuxServer-CI closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2023
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Dec 28, 2023
Copy link

This issue is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants