Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Note 8.12: Zapper Remove Manager Requires Increased Trust #506

Open
bingen opened this issue Oct 9, 2024 · 1 comment
Open

CS Note 8.12: Zapper Remove Manager Requires Increased Trust #506

bingen opened this issue Oct 9, 2024 · 1 comment
Assignees
Labels
ChainSecurity wontfix This will not be worked on Zappers

Comments

@bingen
Copy link
Collaborator

bingen commented Oct 9, 2024

The zappers implement the same delegation scheme as the core system. There is a removeManager and a receiver, that can be set to different addresses. In the core system, the removeManager cannot directly profit or cause losses by making malicious changes, because the receiver will receive the funds.

In the zappers, the removeManager can directly profit and cause losses by making malicious changes, because they can decide the parameters of the swaps made in the leverage functions. Swapping at bad exchange rates (and sandwiching those swaps) can cause losses to the owner of the trove.

As a result, the trust required in a removeManager that is not also the receiver is higher in the zapper than in the core system.

@bingen bingen self-assigned this Oct 9, 2024
@bingen bingen added the wontfix This will not be worked on label Oct 9, 2024
@bingen
Copy link
Collaborator Author

bingen commented Oct 9, 2024

This is a natural consequence of the increased power (perform swaps) that Leverage Zappers have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChainSecurity wontfix This will not be worked on Zappers
Projects
None yet
Development

No branches or pull requests

1 participant