Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecate] JHUData.from_dataframe() and JHUData.replace() #905

Closed
lisphilar opened this issue Jul 26, 2021 · 0 comments · Fixed by #906
Closed

[Deprecate] JHUData.from_dataframe() and JHUData.replace() #905

lisphilar opened this issue Jul 26, 2021 · 0 comments · Fixed by #906
Labels
enhancement New feature or request
Milestone
Release v2.22.0

Comments

@lisphilar
Copy link
Owner

Summary of request

JHUData.from_dataframe() and JHUData.replace() will be deprecated because users can load local CSV files with DataLoader directly with #851.

The current Version

CovsirPhy version: 2.21.0-xi-fu1
@lisphilar lisphilar added the enhancement New feature or request label Jul 26, 2021
@lisphilar lisphilar added this to the Release v2.22.0 milestone Jul 26, 2021
@lisphilar lisphilar mentioned this issue Jul 26, 2021
Merged
lisphilar added a commit that referenced this issue Jul 26, 2021
@lisphilar
Merge pull request #906 from lisphilar/issue899_fu
43401cd 
#904, #905, Follow-up #903
lisphilar added a commit that referenced this issue Jul 30, 2021
@lisphilar
Merge pull request #914 from lisphilar/issue912
8bedcbf 
Issue #912. #913, #904 (tests), #905 (tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v2.22.0
Development

Successfully merging a pull request may close this issue.

#904, #905, Follow-up #903 lisphilar/covid19-sir
1 participant
@lisphilar