Skip to content

Commit

Permalink
small clean-ups
Browse files Browse the repository at this point in the history
  • Loading branch information
DataDaoDe committed Jan 27, 2025
1 parent b6ab18a commit 45d3fca
Showing 1 changed file with 5 additions and 14 deletions.
19 changes: 5 additions & 14 deletions advanced_alchemy/utils/databases.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ async def create_database_async(engine: AsyncEngine, database: str | None, encod
pass
else:
async with engine.begin() as conn:
sql = f"CREATE DATABASE {database}"
await conn.execute(text(sql))
await conn.execute(text(f"CREATE DATABASE {database}"))

await engine.dispose()

Expand Down Expand Up @@ -165,14 +164,10 @@ async def drop_database_async(engine: AsyncEngine, database: str | None) -> None
version = conn.dialect.server_version_info
sql = _disconnect_users_sql(version, database)
await conn.execute(text(sql))

# Drop the database.
sql = f"DROP DATABASE {database}"
await conn.execute(text(sql))
await conn.execute(text(f"DROP DATABASE {database}"))
else:
async with engine.begin() as conn:
sql = f"DROP DATABASE {database}"
await conn.execute(text(sql))
await conn.execute(text(f"DROP DATABASE {database}"))

await engine.dispose()

Expand All @@ -188,13 +183,9 @@ def drop_database_sync(engine: Engine, database: str | None) -> None:
version = conn.dialect.server_version_info
sql = _disconnect_users_sql(version, database)
conn.execute(text(sql))

# Drop the database.
sql = f"DROP DATABASE {database}"
conn.execute(text(sql))
conn.execute(text(f"DROP DATABASE {database}"))
else:
with engine.begin() as conn:
sql = f"DROP DATABASE {database}"
conn.execute(text(sql))
conn.execute(text(f"DROP DATABASE {database}"))

engine.dispose()

0 comments on commit 45d3fca

Please sign in to comment.