Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: the CI will fail currently since there are no tests #8

Open
4 tasks
guacs opened this issue Nov 15, 2023 · 4 comments
Open
4 tasks

Bug: the CI will fail currently since there are no tests #8

guacs opened this issue Nov 15, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@guacs
Copy link
Member

guacs commented Nov 15, 2023

Description

pytest returns an exit code of 5 when it finds no tests. This causes the CI to fail. I think there are two options:

  • disable the tests as part of the CI for this repo until tests are added
  • use pytest_sessionfinish to change the exit code to 0 if the exit code is 5

URL to code causing the issue

No response

MCVE

# Your MCVE code here

Steps to reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots

No response

Logs

No response

Litestar Version

...

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)
@guacs guacs added the bug Something isn't working label Nov 15, 2023
@guacs
Copy link
Member Author

guacs commented Nov 15, 2023

@JacobCoffee can we update the issues templates to ask for the version of litestar-asyncpg along with the litestar version? I didn't see a ISSUES in the .github folder and I'm not sure how the templates are set up currently.

@JacobCoffee
Copy link
Member

They are community health files that propagate to all repos here: https://github.com/litestar-org/.github

Maybe can change them there to just be "Package Version" instead?

@JacobCoffee
Copy link
Member

Updated that to be Package Version instead

@guacs
Copy link
Member Author

guacs commented Nov 18, 2023

Updated that to be Package Version instead

I think it would be nice if we can ask for both the version of litestar as well as the package (if it's a litestar related plugin or something).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants