suggested fixes

litestar-org · Jan 15, 2025 · 656a259 · 656a259
1 parent 55968c2
commit 656a259
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/deploy/docker/dev/Dockerfile b/deploy/docker/dev/Dockerfile
@@ -67,12 +67,13 @@ COPY src ./src/
 FROM build-base AS dev-image
 ARG ENV_SECRETS="runtime-secrets"
 ARG LITESTAR_APP="app.asgi:create_app"
-ARG VITE_USE_SERVER_LIFESPAN="false"
+ARG VITE_USE_SERVER_LIFESPAN="true"
 ARG SAQ_USE_SERVER_LIFESPAN="false"
 ## --------------------------- standardize execution env ----------------------------- ##
 ENV PATH="/workspace/app/.venv/bin:$PATH" \
   VIRTUAL_ENV="/workspace/app/.venv" \
   ENV_SECRETS="${ENV_SECRETS}"  \
+  VITE_DEV_MODE=True  \
   VITE_USE_SERVER_LIFESPAN="${VITE_USE_SERVER_LIFESPAN}" \
   SAQ_USE_SERVER_LIFESPAN="${SAQ_USE_SERVER_LIFESPAN}" \
   PIP_DEFAULT_TIMEOUT=100 \
@@ -91,7 +92,7 @@ COPY tests/ tests/
 COPY src src/
 RUN uv sync ${UV_INSTALL_ARGS}
 STOPSIGNAL SIGINT
-EXPOSE 8000
+EXPOSE 8080
 ENTRYPOINT ["tini","--" ]
 CMD [ "litestar","run","--host","0.0.0.0"]
 VOLUME /workspace/app
diff --git a/docker-compose.override.yml b/docker-compose.override.yml
@@ -27,10 +27,7 @@ services:
       - "8080:8080"
       - "3006:3006"
     tty: true
-    environment:
-      VITE_USE_SERVER_LIFESPAN: "true" # true in dev or run
-      SAQ_USE_SERVER_LIFESPAN: "false"
-    command: litestar run --reload --host 0.0.0.0 --port 8000
+    command: litestar run --reload --host 0.0.0.0 --port 8080
     restart: always
     <<: *development-volumes
   worker:

diff --git a/src/app/config/base.py b/src/app/config/base.py
@@ -201,7 +201,7 @@ class ServerSettings:
 
     HOST: str = field(default_factory=get_env("LITESTAR_HOST", "0.0.0.0"))  # noqa: S104
     """Server network host."""
-    PORT: int = field(default_factory=get_env("LITESTAR_PORT", 8000))
+    PORT: int = field(default_factory=get_env("LITESTAR_PORT", 8080))
     """Server port."""
     KEEPALIVE: int = field(default_factory=get_env("LITESTAR_KEEPALIVE", 65))
     """Seconds to hold connections open (65 is > AWS lb idle timeout)."""
@@ -347,7 +347,7 @@ class AppSettings:
 
     APP_LOC: str = "app.asgi:create_app"
     """Path to app executable, or factory."""
-    URL: str = field(default_factory=get_env("APP_URL", "http://localhost:8000"))
+    URL: str = field(default_factory=get_env("APP_URL", "http://localhost:8080"))
     """The frontend base URL"""
     DEBUG: bool = field(default_factory=get_env("LITESTAR_DEBUG", False))
     """Run `Litestar` with `debug=True`."""