-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Kubernetes Ansible modules instead of embedding it into the shell #39
Comments
Awesome @crazyglasses ! That would be great ! Moving to |
Tagging @uditgaurav who has been working on a similar PR! |
Thanks, @ksatchit for tagging me here @crazyglasses that's great I've been working on it and I have converted various shell commands into k8s and k8s_facts module. I have faced some issues in few commands explained below. I'll be happy to accept the contribution for such issues.
ANSIBLE VERSION
SHELL COMMAND
USING K8S MODULE
PROBLEM STATEMENT so what I think is k8s module is treating it as " |
@uditgaurav Can you please share which all files you have refactored so far and which you are planning to work on? I've started changing pod_failure_by_litmus file and planning to work on remaining yml files under chaoslib folder, if you haven't worked on those already. |
@kmjayadeep You can carry on for remaining yml files under chaoslib. I've changed the yml files under /utils. |
Is this a BUG REPORT or FEATURE REQUEST?
FEATURE REQUEST
What happened:
Observed that current experiments are written with kubectl commands embedded in the shell commands. Recommend replacing it with Ansible modules for kubernetes. Eg: https://docs.ansible.com/ansible/latest/modules/k8s_module.html#synopsis
What you expected to happen:
If modules are embedded in the image, easier development process for new experiments as well as cleaner ansible code.
How to reproduce it (as minimally and precisely as possible):
Source Code analysis
Anything else we need to know?:
It is a recommendation. Would be happy to take up and convert the existing scripts to include modules and bake it into the image as well.
The text was updated successfully, but these errors were encountered: