Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema output is not being sent as empty when there is not return type in LHTaskMethod in Java and Dotnet SDKs #1168

Closed
KarlaCarvajal opened this issue Nov 28, 2024 · 1 comment · Fixed by #1169 or #1170
Assignees
Labels
bug An issue with correctness, stability, performance, or API conformance. sdk-dotnet Affects the .NET SDK (not all clients). sdk-java Affects the Java SDK (not all clients).

Comments

@KarlaCarvajal
Copy link
Contributor

KarlaCarvajal commented Nov 28, 2024

Context

When using a method that returns a void type it is parsing into a LHVariableType JSON_OBJ in the schema output of the TaskDef, this is placed while creates the lh method signature.

This is happening in the Java and Dotnet SDKs

Steps To Reproduce

Create a Task Worker in Java or Dotnet and generate a method with a void returned value, the taskDef will be registered a Schema Output with a JSON object as result type, which is incorrect

The wrong one is:
{ "id": { "name": "fail" }, "inputVars": [], "createdAt": "2024-11-28T15:46:00.277Z", "schemaOutput": { "valueDef": { "type": "JSON_OBJ", "name": "output", "maskedValue": false } } }

Expected Behavior

When there is not a return type as it is the void case in Java and Dotnet, it should not set a schema output in the taskDef

The correct one is:

{ "name": "complete-order", "inputVars": [ { "type": "STR", "name": "order_id" } ] }

Screenshots

No response

Additional Context

No response

Components

No response

@KarlaCarvajal KarlaCarvajal added bug An issue with correctness, stability, performance, or API conformance. sdk-java Affects the Java SDK (not all clients). sdk-dotnet Affects the .NET SDK (not all clients). labels Nov 28, 2024
@KarlaCarvajal KarlaCarvajal self-assigned this Nov 28, 2024
@KarlaCarvajal
Copy link
Contributor Author

There is still missing the Java fix to be completed this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with correctness, stability, performance, or API conformance. sdk-dotnet Affects the .NET SDK (not all clients). sdk-java Affects the Java SDK (not all clients).
Projects
None yet
1 participant