Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix lh_ on Prometheus Metrics for lh-server #1194

Open
mijailr opened this issue Dec 13, 2024 · 2 comments
Open

Prefix lh_ on Prometheus Metrics for lh-server #1194

mijailr opened this issue Dec 13, 2024 · 2 comments
Labels
feature Issue that denotes a new feature, request, or performance improvement. server Affects the core LH Server code.

Comments

@mijailr
Copy link
Contributor

mijailr commented Dec 13, 2024

I would like to request the addition of a lh_ prefix to all Prometheus metrics exposed by the lh-server. This change can improve the clarity and uniformity of metrics, especially when integrating with other systems or when multiple services expose metrics to the same Prometheus instance.

@mijailr mijailr added feature Issue that denotes a new feature, request, or performance improvement. server Affects the core LH Server code. labels Dec 13, 2024
@coltmcnealy-lh
Copy link
Member

This would be a breaking change. Adding it to the 1.0 milestone.

@coltmcnealy-lh coltmcnealy-lh added this to the LittleHorse 1.0 milestone Feb 19, 2025
@coltmcnealy-lh
Copy link
Member

coltmcnealy-lh commented Feb 19, 2025

Actually, after 5 seconds more thought, we could do this through a configuration: LHS_METRICS_PREFIX. It could default to the empty string. Operators of LittleHorse could opt-in to lh_ if they want. That would be the most flexible and best approach, and it wouldn't require a breaking change. Removing from the milestone (with apologies to our Grumpy Maintainer for the chaos).

@coltmcnealy-lh coltmcnealy-lh removed this from the LittleHorse 1.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue that denotes a new feature, request, or performance improvement. server Affects the core LH Server code.
Projects
None yet
Development

No branches or pull requests

2 participants